From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: ashishj3 <ashish.jangam@kpitcummins.com>
Cc: sameo@openedhand.com, linux-kernel@vger.kernel.org,
Dajun <dajun.chen@diasemi.com>,
linaro-dev@lists.linaro.org, arnd@arndb.de
Subject: Re: [PATCH 01/11] MFD: DA9052/53 MFD core module v6
Date: Mon, 26 Sep 2011 10:56:11 +0100 [thread overview]
Message-ID: <20110926095611.GA15452@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1316435596.344.132.camel@L-0761.kpit.com>
On Mon, Sep 19, 2011 at 06:03:16PM +0530, ashishj3 wrote:
> The DA9052/53 is a highly integrated PMIC subsystem with supply domain flexibility
> to support wide range of high performance application.
>
> It provides voltage regulators, GPIO controller, Touch Screen, RTC, Battery
> control and other functionality.
So, this looks good. However...
> +static struct regmap_config da9052_regmap_config = {
> + .reg_bits = 8,
> + .val_bits = 8,
> +};
> +
> +static int da9052_spi_probe(struct spi_device *spi)
...having reviewed previous versions of your driver I believe you need
to set either or both of read_flag_mask or write_flag_mask your regmap
config (these have been added in -next) - previous versions of your
driver had code which was trying to bodge this in, you've removed this
code but not added any use of the generic facility so I rather suspect
that currently the driver doesn't work with SPI.
Samuel, as a fix will depend on -next regmap I guess it makes sense for
me to apply this if a new version is provided before the next merge
window?
next prev parent reply other threads:[~2011-09-26 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 12:33 [PATCH 01/11] MFD: DA9052/53 MFD core module v6 ashishj3
2011-09-26 9:12 ` Eric Miao
2011-09-29 15:55 ` Samuel Ortiz
2011-09-26 9:56 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-09-19 12:32 ashishj3
2011-10-12 5:07 ` Ying-Chun Liu (PaulLiu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926095611.GA15452@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=ashish.jangam@kpitcummins.com \
--cc=dajun.chen@diasemi.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.