All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon/mc13xxx-adc: add support for the
Date: Mon, 26 Sep 2011 15:54:47 +0000	[thread overview]
Message-ID: <20110926155447.GH20550@pengutronix.de> (raw)
In-Reply-To: <1317049670-8049-1-git-send-email-u.kleine-koenig@pengutronix.de>

Hello Guenter,

> renaming the file makes it technically impossible to review the changes.
oh, I forgot to add -M to format-patch. I can resend when we agree on
renaming or not. But note that even then there are many hunks as I did
s/mc13783/mc13xxx/ in the driver.

> Please refrain from it, and use the mechanism used for other hwmon
> drivers - add support for the new chip to the old driver, and reference
> the supported chips in Kconfig and the driver documentation.
Ah, I missed to rename Documentation/hwmon/mc13783-adc. Will update that
on v2.

> Besides, the new name implies that all future MC13XXX chips would be
> supported by this driver, which seems to be a bit difficult to predict.
hmm, but today mc13xxx is the best name we have. And I prefer a driver
named mc13xxx over mc13783 because when looking for a driver for the
mc13892 and seeing only mc13783-adc I'd assume it doesn't support
mc13892. OTOH if there is a mc13xxx-adc driver I'd look in more detail
if my chip is supported.

So if you ask me, use the best name available today and think about the
best naming again when the next chip comes up that fits the naming
scheme but not the driver.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2011-09-26 15:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26 15:07 [lm-sensors] [PATCH] hwmon/mc13xxx-adc: add support for the MC13892 Uwe Kleine-König
2011-09-26 15:15 ` [lm-sensors] [PATCH] hwmon/mc13xxx-adc: add support for the Guenter Roeck
2011-09-26 15:54 ` Uwe Kleine-König [this message]
2011-09-26 16:08 ` Jean Delvare
2011-09-27  6:44 ` David Jander
2011-09-27  8:12 ` Wolfram Sang
2011-09-27  9:06 ` David Jander
2011-09-27  9:22 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110926155447.GH20550@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.