From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: serge@hallyn.com, qemu-devel@nongnu.org, anbang.ruan@cs.ox.ac.uk,
andreas.niederl@iaik.tugraz.at
Subject: Re: [Qemu-devel] [PATCH V9 1/5] Support for TPM command line options
Date: Mon, 26 Sep 2011 22:03:47 +0300 [thread overview]
Message-ID: <20110926190347.GC22278@redhat.com> (raw)
In-Reply-To: <20110926163728.368010654@linux.vnet.ibm.com>
On Mon, Sep 26, 2011 at 12:35:10PM -0400, Stefan Berger wrote:
> +void tpm_display_backend_drivers(FILE *out)
> +{
> + int i;
> +
> + fprintf(out, "Supported TPM types (choose only one):\n");
> +
> + for (i = 0; bes[i] != NULL; i++) {
> + fprintf(out, "%12s %s",
> + bes[i]->id, bes[i]->desc());
> + fprintf(out, "\n");
> + }
> + fprintf(out, "\n");
> +}
This dumps to stderr and so for qmp users it won't be correctly ordered.
I'd suggest simply using error_report. This means '?' goes to stderr,
not stdout, but that is consistent with e.g. -device '?'.
next prev parent reply other threads:[~2011-09-26 19:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 16:35 [Qemu-devel] [PATCH V9 0/5] Qemu Trusted Platform Module (TPM) integration Stefan Berger
2011-09-26 16:35 ` [Qemu-devel] [PATCH V9 1/5] Support for TPM command line options Stefan Berger
2011-09-26 19:03 ` Michael S. Tsirkin [this message]
2011-09-26 23:33 ` Stefan Berger
2011-09-26 16:35 ` [Qemu-devel] [PATCH V9 2/5] Add TPM (frontend) hardware interface (TPM TIS) to Qemu Stefan Berger
2011-09-26 19:09 ` Michael S. Tsirkin
2011-09-26 19:09 ` Avi Kivity
2011-09-27 1:48 ` Stefan Berger
2011-09-27 5:28 ` Michael S. Tsirkin
2011-09-26 16:35 ` [Qemu-devel] [PATCH V9 3/5] Add a debug register Stefan Berger
2011-09-26 16:35 ` [Qemu-devel] [PATCH V9 4/5] Build the TPM frontend code Stefan Berger
2011-09-26 16:35 ` [Qemu-devel] [PATCH V9 5/5] Add a TPM Passthrough backend driver implementation Stefan Berger
2011-09-26 19:20 ` Michael S. Tsirkin
2011-09-26 20:12 ` Stefan Berger
2011-09-26 20:24 ` Michael S. Tsirkin
2011-09-27 2:20 ` Stefan Berger
2011-09-26 19:22 ` [Qemu-devel] [PATCH V9 0/5] Qemu Trusted Platform Module (TPM) integration Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926190347.GC22278@redhat.com \
--to=mst@redhat.com \
--cc=anbang.ruan@cs.ox.ac.uk \
--cc=andreas.niederl@iaik.tugraz.at \
--cc=qemu-devel@nongnu.org \
--cc=serge@hallyn.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.