All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Tejun Heo <htejun@gmail.com>, Luke Macken <lmacken@redhat.com>,
	stable@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH stable-3.0] ptrace: don't clear GROUP_STOP_SIGMASK on double-stop
Date: Mon, 26 Sep 2011 15:15:11 -0700	[thread overview]
Message-ID: <20110926221511.GB19769@suse.de> (raw)
In-Reply-To: <20110926170632.GA16936@redhat.com>

On Mon, Sep 26, 2011 at 07:06:32PM +0200, Oleg Nesterov wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=740121
> 
> 1. Luke Macken triggered WARN_ON(!(group_stop & GROUP_STOP_SIGMASK))
>    in do_signal_stop().
> 
>    This is because do_signal_stop() clears GROUP_STOP_SIGMASK part
>    unconditionally but doesn't update it if task_is_stopped().
> 
> 2. Looking at this problem I noticed that WARN_ON_ONCE(!ptrace) is
>    not right, a stopped-but-resumed tracee can clone the untraced
>    thread in the SIGNAL_STOP_STOPPED group, the new thread can start
>    another group-stop.
> 
>    Remove this warning, we need more fixes to make it true.
> 
> Reported-by: Luke Macken <lmacken@redhat.com>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Is this fix in Linus's tree already?  If so, what's the git commit id?

If not, please take a look at Documentation/stable_kernel_rules.txt for
how to properly submit a patch to the stable tree.

thanks,

greg k-h

  parent reply	other threads:[~2011-09-26 22:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26 17:06 [PATCH stable-3.0] ptrace: don't clear GROUP_STOP_SIGMASK on double-stop Oleg Nesterov
2011-09-26 17:07 ` Oleg Nesterov
2011-09-26 22:15 ` Greg KH [this message]
2011-09-27 12:54   ` Oleg Nesterov
2011-10-19 23:00 ` Greg KH
2011-10-20 14:47   ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110926221511.GB19769@suse.de \
    --to=gregkh@suse.de \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lmacken@redhat.com \
    --cc=oleg@redhat.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.