From: Alan Cox <alan@linux.intel.com>
To: Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com>
Cc: linux-serial@vger.kernel.org, gregkh@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] tty/n_gsm: avoid fifo overflow in gsm_dlci_data_output
Date: Tue, 27 Sep 2011 11:59:57 +0100 [thread overview]
Message-ID: <20110927115957.5e6cb79c@bob.linux.org.uk> (raw)
In-Reply-To: <1316791376-4863-2-git-send-email-mikhail.kshevetskiy@gmail.com>
On Fri, 23 Sep 2011 19:22:56 +0400
Mikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com> wrote:
> n_gsm use a simple approach: every writing to fifo correspond exactly
> one reading from fifo. There are no problem in this approach until we
> read less bytes then we write. As result fifo may owerflow. This
> leads to packet loss and very slow responce.
We do need to do something here but your change means a single DLCI
will hog the channel, so I think the while loop needs to be one layer
up.
Alan
next prev parent reply other threads:[~2011-09-27 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 15:22 [PATCH 1/2] tty/n_gsm: fix a bug in gsm_dlci_data_output (adaption = 2 case) Mikhail Kshevetskiy
2011-09-23 15:22 ` [PATCH 2/2] tty/n_gsm: avoid fifo overflow in gsm_dlci_data_output Mikhail Kshevetskiy
2011-09-27 10:59 ` Alan Cox [this message]
2011-09-27 10:58 ` [PATCH 1/2] tty/n_gsm: fix a bug in gsm_dlci_data_output (adaption = 2 case) Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110927115957.5e6cb79c@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mikhail.kshevetskiy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.