All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Len Brown <len.brown@intel.com>
Subject: Re: linux-next: manual merge of the rcu tree with Linus' tree
Date: Tue, 27 Sep 2011 14:20:44 +0200	[thread overview]
Message-ID: <20110927122041.GL18553@somewhere> (raw)
In-Reply-To: <20110927160411.7bcec0906847959fb6e88a81@canb.auug.org.au>

On Tue, Sep 27, 2011 at 04:04:11PM +1000, Stephen Rothwell wrote:
> Hi Paul,
> 
> Today's linux-next merge of the rcu tree got a conflict in
> arch/x86/kernel/process_64.c between commit a0bfa1373859 ("cpuidle: stop
> depending on pm_idle") from Linus' tree and commit 18349ca4b42e ("x86:
> Enter rcu extended qs after idle notifier call") from the rcu tree.
> 
> I fixed it up (see below) and can carry the fix as necessary.
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> 
> diff --cc arch/x86/kernel/process_64.c
> index f693e44,dee2e6c..0000000
> --- a/arch/x86/kernel/process_64.c
> +++ b/arch/x86/kernel/process_64.c
> @@@ -137,8 -136,12 +137,14 @@@ void cpu_idle(void
>   			enter_idle();
>   			/* Don't trace irqs off for idle */
>   			stop_critical_timings();
> - 			if (cpuidle_idle_call())
> + 
>  -			/* enter_idle() needs rcu for notifiers */
>  -			rcu_enter_nohz();
>  -			pm_idle();
>  -			rcu_exit_nohz();
> ++			if (cpuidle_idle_call()) {
> ++				/* enter_idle() needs rcu for notifiers */
> ++				rcu_enter_nohz();
>  +				pm_idle();
> ++				rcu_exit_nohz();
> ++			}
> + 
>   			start_critical_timings();
>   
>   			/* In many cases the interrupt that ended idle

Looks good, thanks!

  reply	other threads:[~2011-09-27 12:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27  6:04 linux-next: manual merge of the rcu tree with Linus' tree Stephen Rothwell
2011-09-27 12:20 ` Frederic Weisbecker [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-10-17 22:41 Stephen Rothwell
2022-10-18 18:38 ` Paul E. McKenney
2022-07-08  4:12 Stephen Rothwell
2022-07-08 15:23 ` Paul E. McKenney
2018-06-12  0:46 Stephen Rothwell
2018-06-12  1:01 ` Paul E. McKenney
2018-06-18  3:48 ` Stephen Rothwell
2018-06-18  3:49   ` Stephen Rothwell
2018-06-18 14:48     ` Paul E. McKenney
2018-05-14  3:46 Stephen Rothwell
2018-05-15 17:44 ` Paul E. McKenney
2017-09-26  3:00 Stephen Rothwell
2017-09-26  3:26 ` Paul E. McKenney
2017-09-26  3:42   ` Stephen Rothwell
2017-03-08  0:46 Stephen Rothwell
2017-03-08  0:56 ` Stephen Rothwell
2016-03-30  0:32 Stephen Rothwell
2016-03-30 10:30 ` Paul E. McKenney
2016-03-30  0:23 Stephen Rothwell
2012-11-29  3:06 Stephen Rothwell
2012-11-29 22:12 ` Paul E. McKenney
2012-08-06  2:31 Stephen Rothwell
2011-09-27  5:14 Stephen Rothwell
2011-09-27 13:14 ` Borislav Petkov
2010-10-06  2:38 Stephen Rothwell
2010-10-06  4:17 ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110927122041.GL18553@somewhere \
    --to=fweisbec@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.