All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: tom.leiming@gmail.com, stern@rowland.harvard.edu,
	linux-pm@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, mingo@redhat.com,
	fweisbec@gmail.com, Ming Lei <ming.lei@canonical.com>
Subject: Re: [PATCH v1 1/2] PM/runtime: introduce trace points for tracing rpm_* functions
Date: Tue, 27 Sep 2011 23:03:34 +0200	[thread overview]
Message-ID: <201109272303.34603.rjw@sisk.pl> (raw)
In-Reply-To: <1317156234.26514.39.camel@gandalf.stny.rr.com>

On Tuesday, September 27, 2011, Steven Rostedt wrote:
> On Tue, 2011-09-27 at 22:36 +0200, Rafael J. Wysocki wrote:
> 
> > > 	TP_printk("%pS:%s ret=%d", (void *)__entry->ip, __get_str(name),
> > > 		__entry->ret)
> > > 
> > > try that.
> > 
> > Well, that certainly will work, but is it the right fix?
> 
> Hehe, yes!  The pS means to take a pointer and return the string version
> of the address. Like "schedule+0x3a". __entry->ip is the address of the
> function that called it __THIS_IP__ but we want to convert that into a
> string name.
> 
> We use ip because both perf and trace-cmd should be smart enough to
> parse it too. As they both store the kallsyms into the data file.
> 
> The (void *) is used because pS wants a pointer, and we stored the
> address as an unsigned long.

OK, good.

I've applied both patches (with the above fix folded into the first one)
to linux-pm/pm-runtime (and merged into my linux-next branch), so they will be
pushed for 3.2.

Thanks,
Rafael

  reply	other threads:[~2011-09-27 21:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27 10:12 [PATCH v1 1/2] PM/runtime: introduce trace points for tracing rpm_* functions tom.leiming
2011-09-27 10:12 ` tom.leiming
2011-09-27 20:06   ` Rafael J. Wysocki
2011-09-27 20:13     ` Steven Rostedt
2011-09-27 20:29   ` Rafael J. Wysocki
2011-09-27 20:31     ` Steven Rostedt
2011-09-27 20:36       ` Rafael J. Wysocki
2011-09-27 20:43         ` Steven Rostedt
2011-09-27 21:03           ` Rafael J. Wysocki [this message]
2011-09-27 10:12 ` [PATCH v1 2/2] PM/runtime: replace dev_dbg with trace_rpm_* tom.leiming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109272303.34603.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=ming.lei@canonical.com \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.