From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 8/8] regmap: Ensure we scream if we enable cache bypass/only at the same time
Date: Thu, 29 Sep 2011 11:25:30 +0100 [thread overview]
Message-ID: <20110929102530.GJ3697@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1317289153-21123-8-git-send-email-dp@opensource.wolfsonmicro.com>
On Thu, Sep 29, 2011 at 10:39:13AM +0100, Dimitris Papastamos wrote:
> void regcache_cache_only(struct regmap *map, bool enable)
> {
> + BUG_ON(map->cache_bypass && enable);
> mutex_lock(&map->lock);
I'd move these inside the lock otherwise there's an enable/enable race
where two threads check that things are safe simultaneously. I'd also
change to WARN_ON(), if nothing else it's hard to see BUG_ON()s that
occur prior to console output and PMICs are likely to trigger that sort
of stuff.
next prev parent reply other threads:[~2011-09-29 10:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 9:39 [PATCH 1/8] Revert "regmap: Grab the lock in regcache_cache_only()" Dimitris Papastamos
2011-09-29 9:39 ` [PATCH 2/8] regmap: Make _regmap_write() global Dimitris Papastamos
2011-09-29 10:19 ` Mark Brown
2011-09-29 10:20 ` Mark Brown
2011-09-29 9:39 ` [PATCH 3/8] regmap: Use the lockless _regmap_write() for syncing Dimitris Papastamos
2011-09-29 9:39 ` [PATCH 4/8] regmap: Guard regcache_sync() with map->lock Dimitris Papastamos
2011-09-29 10:22 ` Mark Brown
2011-09-29 13:26 ` Dimitris Papastamos
2011-09-29 9:39 ` [PATCH 5/8] regmap: Save/restore the bypass state upon syncing Dimitris Papastamos
2011-09-29 9:39 ` [PATCH 6/8] regmap: Grab the lock in regcache_cache_only() Dimitris Papastamos
2011-09-29 9:39 ` [PATCH 7/8] regmap: Implement regcache_cache_bypass helper function Dimitris Papastamos
2011-09-29 9:39 ` [PATCH 8/8] regmap: Ensure we scream if we enable cache bypass/only at the same time Dimitris Papastamos
2011-09-29 10:25 ` Mark Brown [this message]
2011-09-29 13:24 ` Dimitris Papastamos
2011-09-29 10:18 ` [PATCH 1/8] Revert "regmap: Grab the lock in regcache_cache_only()" Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110929102530.GJ3697@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.