From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] tools/check: check for yajl (needed by
	libxl)
Date: Fri, 30 Sep 2011 14:15:42 +0200
Message-ID: <20110930121542.GA25896@aepfle.de>
References: <4b98868690218126b906.1317368189@cosworth.uk.xensource.com>
	<20110930120210.GA25618@aepfle.de>
	<1317384428.26672.269.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <1317384428.26672.269.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Sep 30, Ian Campbell wrote:

> On Fri, 2011-09-30 at 13:02 +0100, Olaf Hering wrote:
> > On Fri, Sep 30, Ian Campbell wrote:
> > 
> > > (note to committer, ensure the new file is executable)
> > 
> > Please dont, thats not patch friendly.
> > 
> > Shouldnt all script files be called with like 
> > '$interpreter $script' instead of './$script'?
> 
> In general I agree, but that isn't how it the infrastructure in
> tools/check/chk works right now.

There is tools/check/check_logging, which says it requires code with is
included in Python 2.3 and later.
The toplevel README states 2.3 or later is required, so
tools/check/check_logging could be removed and line 63 in
tools/check/chk be updated.

Olaf