From: Vivek Goyal <vgoyal@redhat.com>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Cc: Simon Horman <horms@verge.net.au>,
kexec@lists.infradead.org, ying.huang@intel.com
Subject: Re: kexec: load-preserve-context option on s390
Date: Fri, 30 Sep 2011 12:06:55 -0400 [thread overview]
Message-ID: <20110930160655.GD25891@redhat.com> (raw)
In-Reply-To: <1317303511.3494.2.camel@br98xy6r>
On Thu, Sep 29, 2011 at 03:38:31PM +0200, Michael Holzheu wrote:
> Hello Vivec,
Right spelling is "Vivek" and not "Vivec" :-)
[..]
> > Shouldn't kexec system call return error if KEXEC_JUMP is not supported
> > and user asked for it?
>
> I think currently not. I assume that we should check the
> KEXEC_PRESERVE_CONTEXT flag in the kexec_load system call.
>
Shouldn't following existing code take care of this already?
/*
* Verify we have a legal set of flags
* This leaves us room for future extensions.
*/
if ((flags & KEXEC_FLAGS) != (flags & ~KEXEC_ARCH_MASK))
return -EINVAL;
In include/linux/kexec.h, we have following.
/* List of defined/legal kexec flags */
#ifndef CONFIG_KEXEC_JUMP
#define KEXEC_FLAGS KEXEC_ON_CRASH
#else
#define KEXEC_FLAGS (KEXEC_ON_CRASH | KEXEC_PRESERVE_CONTEXT)
#endif
Not sure why it is not working.
Thanks
Vivek
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2011-09-30 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 13:09 kexec: load-preserve-context option on s390 Michael Holzheu
2011-09-28 23:51 ` Simon Horman
2011-09-29 13:32 ` Vivek Goyal
2011-09-29 13:38 ` Michael Holzheu
2011-09-30 16:06 ` Vivek Goyal [this message]
2011-10-04 14:07 ` Michael Holzheu
2011-10-04 14:55 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930160655.GD25891@redhat.com \
--to=vgoyal@redhat.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.