From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: PME via interrupt or SCI mechanism?
Date: Sat, 1 Oct 2011 22:29:55 +0200 [thread overview]
Message-ID: <201110012229.55473.rjw@sisk.pl> (raw)
In-Reply-To: <20111001003010.GA26349@xanatos>
On Saturday, October 01, 2011, Sarah Sharp wrote:
> On Fri, Sep 30, 2011 at 10:21:06PM +0200, Rafael J. Wysocki wrote:
> > OK, please test the appended patch. The difference is that it should only
> > continuously poll devices that don't get notifications. You'll still see
> > the debug messages from your previous patches, but this one should be a bit
> > less wasteful than the previous one in general.
>
> This patch seems to work. The GPE fires and the xHCI host controller
> comes out of D3 after a stream of:
>
> Sep 30 17:07:32 talon kernel: [ 197.745312] ehci_hcd 0000:00:1d.0: pci_acpi_wake_dev
> Sep 30 17:07:32 talon kernel: [ 197.745321] ehci_hcd 0000:00:1a.0: pci_acpi_wake_dev
> Sep 30 17:07:32 talon kernel: [ 197.745326] snd_hda_intel 0000:00:1b.0: pci_acpi_wake_dev
> Sep 30 17:07:32 talon kernel: [ 197.745331] e1000e 0000:00:19.0: pci_acpi_wake_dev
>
> It does seem to take less time to come out of D3 than the previous patch
> though.
>
> I occasionally do not see the host controller come out of D3 when I plug
> in a new device, but the interrupt count for GPE 0D doesn't increment
> when that happens, so it's probably just a BIOS or hardware bug.
I think the controller doesn't signal PME in those cases.
> Did mention this was bleeding edge hardware?
No, you didn't, but that doesn't matter a lot. Bugs of this kind are found in
systems being sold in the market too and we need to work around them anyway. :-(
Thanks for testing the patch, I'll resent it with a changelog shortly.
Rafael
prev parent reply other threads:[~2011-10-01 20:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 17:10 PME via interrupt or SCI mechanism? Sarah Sharp
2011-09-19 21:43 ` Rafael J. Wysocki
[not found] ` <20110922183201.GA4659@xanatos>
2011-09-25 14:53 ` Rafael J. Wysocki
2011-09-26 22:20 ` Rafael J. Wysocki
2011-09-26 23:48 ` Sarah Sharp
2011-09-27 11:21 ` Luming Yu
2011-09-27 11:21 ` Luming Yu
2011-09-27 20:32 ` Rafael J. Wysocki
2011-09-28 3:10 ` Luming Yu
2011-09-28 3:10 ` Luming Yu
2011-09-27 20:54 ` Rafael J. Wysocki
2011-09-27 23:52 ` Sarah Sharp
2011-09-28 22:21 ` Rafael J. Wysocki
2011-09-29 1:40 ` Matthew Garrett
2011-09-29 9:05 ` Rafael J. Wysocki
2011-09-29 18:23 ` Sarah Sharp
2011-09-29 19:39 ` Rafael J. Wysocki
2011-09-29 20:44 ` Sarah Sharp
2011-09-29 21:28 ` Rafael J. Wysocki
2011-09-29 21:38 ` Rafael J. Wysocki
2011-09-29 21:51 ` Rafael J. Wysocki
[not found] ` <20110929225700.GA6207@xanatos>
2011-09-30 16:40 ` Rafael J. Wysocki
2011-09-30 20:21 ` Rafael J. Wysocki
2011-10-01 0:30 ` Sarah Sharp
2011-10-01 20:29 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110012229.55473.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.