From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 3/3] drm/i915: kicking rings considered
 harmful
Date: Sat, 1 Oct 2011 23:09:33 -0700
Message-ID: <20111001230933.11d9ebf5@bwidawsk.net>
References: <1317521719-5264-1-git-send-email-ben@bwidawsk.net>
	<1317521719-5264-4-git-send-email-ben@bwidawsk.net>
	<87pqighwm7.fsf@eliezer.anholt.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id E11B69E937
	for <intel-gfx@lists.freedesktop.org>;
	Sat,  1 Oct 2011 23:09:44 -0700 (PDT)
In-Reply-To: <87pqighwm7.fsf@eliezer.anholt.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Eric Anholt <eric@anholt.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sat, 01 Oct 2011 20:59:28 -0700
Eric Anholt <eric@anholt.net> wrote:

> On Sat,  1 Oct 2011 19:15:19 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> > From: Daniel Vetter <daniel.vetter@ffwll.ch>
> > 
> > Only do it in the hope of resurrecting the gpu. Disable when reset is
> > disabled because it seems to tremendously increases our changes to
> > actually capture an error_state before the system goes all belly-up.
> 
> This patch needs a better subject, like "Disable stuck semaphore kick when
> GPU reset is disabled", instead of something suggesting that kicking
> rings is bad in general and going to be removed by the patch.

I'm in favor of removing the ring kick code. I've never seen it actually work,
and Chris mentioned something on IRC about how it's no longer quite as
necessary. I'll let Daniel handle the authoritative response though.


Ben