From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 3 Oct 2011 02:15:15 -0400
Subject: [U-Boot] [PATCH v3 06/21] sandbox: Add architecture lib files
In-Reply-To: <1317082255-24247-7-git-send-email-sjg@chromium.org>
References: <1317082255-24247-1-git-send-email-sjg@chromium.org>
	<1317082255-24247-7-git-send-email-sjg@chromium.org>
Message-ID: <201110030215.16719.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, September 26, 2011 20:10:40 Simon Glass wrote:
> +	gd->mon_len = 0; /* _bss_end_ofs;*/

i'd scrub references to this and drop it from the global header

> +	size = 128 * 1024 * 1024;
> +	mem = malloc(size);
> +	assert(mem);
> +	gd->ram_buf = mem;

shouldn't this 128 MiB be a config ?

> +#ifdef CONFIG_POST
> +	post_bootmode_init();
> +	post_run(NULL, POST_ROM | post_bootmode_get(0));
> +#endif

i wonder if you shouldn't just drop all the POST stuff for now ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111003/275e299a/attachment.pgp