From: Ben Widawsky <ben@bwidawsk.net>
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: blitter ring workaround for gen6
Date: Mon, 3 Oct 2011 04:38:03 +0000 [thread overview]
Message-ID: <20111003043803.GA5236@cloud01> (raw)
In-Reply-To: <yunipo6r9in.fsf@aiko.keithp.com>
[-- Attachment #1.1: Type: text/plain, Size: 1041 bytes --]
On Sun, Oct 02, 2011 at 09:20:32PM -0700, Keith Packard wrote:
> On Sun, 2 Oct 2011 18:27:12 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
>
> > +static void blt_ring_begin2(struct intel_ring_buffer *ring)
> > +{
> > + if (!ring->private)
> > + return;
> > +
> > + intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
> > + intel_ring_emit(ring, 0x2209c);
> > + intel_ring_emit(ring, 0x20002);
> > + intel_ring_emit(ring, MI_FLUSH_DW);
> > + intel_ring_emit(ring, 0x2209c);
> > + intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
> > + intel_ring_emit(ring, 0x2209c);
> > + intel_ring_emit(ring, 0x20000);
> > + intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
> > + intel_ring_emit(ring, 0x2209c);
> > + intel_ring_emit(ring, 0x20000);
> > + intel_ring_emit(ring, MI_NOOP);
> > +}
> > +
>
> Surely you can provide symbolic names here.
>
Of course. I lazily just copied the docs hoping someone would come up with some
reason not to bother going further.
Assuming nobody has any complains, I'll fix it up.
Ben
[-- Attachment #1.2: Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-10-03 4:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 1:27 [PATCH] drm/i915: blitter ring workaround for gen6 Ben Widawsky
2011-10-03 4:20 ` Keith Packard
2011-10-03 4:38 ` Ben Widawsky [this message]
2011-10-03 7:00 ` Chris Wilson
2011-10-03 7:57 ` Ben Widawsky
2011-10-03 8:55 ` Ben Widawsky
2011-10-03 7:41 ` Daniel Vetter
2011-10-03 7:59 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111003043803.GA5236@cloud01 \
--to=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.