Re: [mdadm PATCH] Fix small memory leak

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

On Sun, 02 Oct 2011 21:45:41 +0200 Thomas Jarosch
<thomas.jarosch@intra2net.com> wrote:

> Credit goes to cppcheck.
> 
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> ---
>  policy.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/policy.c b/policy.c
> index 2bbbac8..4a6ef82 100644
> --- a/policy.c
> +++ b/policy.c
> @@ -757,8 +757,10 @@ int policy_check_path(struct mdinfo *disk, struct map_ent *array)
>  
>  	snprintf(path, PATH_MAX, FAILED_SLOTS_DIR "/%s", id_path);
>  	f = fopen(path, "r");
> -	if (!f)
> +	if (!f) {
> +		free(id_path);
>  		return 0;
> +	}
>  
>  	rv = fscanf(f, " %s %x:%x:%x:%x\n",
>  		    array->metadata,
> @@ -767,6 +769,7 @@ int policy_check_path(struct mdinfo *disk, struct map_ent *array)
>  		    array->uuid+2,
>  		    array->uuid+3);
>  	fclose(f);
> +	free(id_path);
>  	return rv == 5;
>  }
>  


applied.  Thanks.

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 190 bytes --]