From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 3/3] drm/i915: kicking rings considered
 harmful
Date: Mon, 3 Oct 2011 10:58:02 +0200
Message-ID: <20111003085802.GC2812@phenom.ffwll.local>
References: <1317521719-5264-1-git-send-email-ben@bwidawsk.net>
	<1317521719-5264-4-git-send-email-ben@bwidawsk.net>
	<87pqighwm7.fsf@eliezer.anholt.net>
	<20111001230933.11d9ebf5@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43])
	by gabe.freedesktop.org (Postfix) with ESMTP id 15A1D9E99B
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  3 Oct 2011 01:57:26 -0700 (PDT)
Received: by wwf27 with SMTP id 27so4379468wwf.12
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 03 Oct 2011 01:57:26 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20111001230933.11d9ebf5@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org, Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Oct 01, 2011 at 11:09:33PM -0700, Ben Widawsky wrote:
> On Sat, 01 Oct 2011 20:59:28 -0700
> Eric Anholt <eric@anholt.net> wrote:
> 
> > On Sat,  1 Oct 2011 19:15:19 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> > > From: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > 
> > > Only do it in the hope of resurrecting the gpu. Disable when reset is
> > > disabled because it seems to tremendously increases our changes to
> > > actually capture an error_state before the system goes all belly-up.
> > 
> > This patch needs a better subject, like "Disable stuck semaphore kick when
> > GPU reset is disabled", instead of something suggesting that kicking
> > rings is bad in general and going to be removed by the patch.
> 
> I'm in favor of removing the ring kick code. I've never seen it actually work,
> and Chris mentioned something on IRC about how it's no longer quite as
> necessary. I'll let Daniel handle the authoritative response though.

Yeah, just kill the stuck semaphore ring kick code. If we deadlock on
semaphores or something like that, we likely have a massive problem and a
full reset sounds like the best course of action. Otoh I think we need to
retain the kick ring stuck in MI_WAIT code, at least to keep on supporting
old (broken) userspace.

Cheers, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48