All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] mmc: sdhci: fix build warning
Date: Mon, 3 Oct 2011 12:45:41 +0200	[thread overview]
Message-ID: <201110031245.41424.marek.vasut@gmail.com> (raw)
In-Reply-To: <1317632501-12336-3-git-send-email-leiwen@marvell.com>

On Monday, October 03, 2011 11:01:39 AM Lei Wen wrote:
> If CONFIG_MMC_SDHCI_IO_ACCESSORS is defined, the following warning would
> shows up:

[...]

> 
> diff --git a/include/sdhci.h b/include/sdhci.h
> index 6d52ce9..6c6a8ea 100644
> --- a/include/sdhci.h
> +++ b/include/sdhci.h
> @@ -219,6 +219,7 @@
>   */
>  #define SDHCI_DEFAULT_BOUNDARY_SIZE	(512 * 1024)
>  #define SDHCI_DEFAULT_BOUNDARY_ARG	(7)
> +struct sdhci_host;
>  struct sdhci_ops {
>  #ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS
>  	u32             (*read_l)(struct sdhci_host *host, int reg);

Dear Lei Wen,

Please keep the newlines so it's not such an uniform blob of code. Thanks!

Cheers

  reply	other threads:[~2011-10-03 10:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-03  9:01 [U-Boot] [PATCH 0/4] fix and enhancement patches for sdhci Lei Wen
2011-10-03  9:01 ` [U-Boot] [PATCH 1/4] mmc: sdhci: fix cache flush Lei Wen
2011-10-03  9:01 ` [U-Boot] [PATCH 2/4] mmc: sdhci: fix build warning Lei Wen
2011-10-03 10:45   ` Marek Vasut [this message]
2011-10-03 11:45     ` Lei Wen
2011-10-03  9:01 ` [U-Boot] [PATCH 3/4] mmc: sdhci: add mmc structure for host Lei Wen
2011-10-03  9:01 ` [U-Boot] [PATCH 4/4] mmc: sdhci: add timeout for data transfer Lei Wen
2011-10-04  6:32 ` [U-Boot] [PATCH V2 0/4] fix and enhancement patches for sdhci Lei Wen
2011-10-08 13:47   ` [U-Boot] [PATCH V3 0/5] " Lei Wen
2011-10-08 14:14     ` [U-Boot] [PATCH V4 " Lei Wen
2011-10-18 14:58       ` Lei Wen
2011-11-02  6:40         ` Lei Wen
2011-11-02 16:37           ` Fleming Andy-AFLEMING
2011-10-08 14:14     ` [U-Boot] [PATCH V4 1/5] mmc: sdhci: fix cache flush Lei Wen
2011-10-08 14:14     ` [U-Boot] [PATCH V4 2/5] mmc: sdhci: fix build warning Lei Wen
2011-10-08 14:14     ` [U-Boot] [PATCH V4 3/5] mmc: sdhci: add mmc structure for host Lei Wen
2011-10-08 14:14     ` [U-Boot] [PATCH V4 4/5] mmc: sdhci: add timeout for data transfer Lei Wen
2011-10-08 14:14     ` [U-Boot] [PATCH V4 5/5] mmc: sdhci: fix sdma bug for large file transfer Lei Wen
2011-10-08 13:47   ` [U-Boot] [PATCH V3 1/5] mmc: sdhci: fix cache flush Lei Wen
2011-10-08 13:47   ` [U-Boot] [PATCH V3 2/5] mmc: sdhci: fix build warning Lei Wen
2011-10-08 13:47   ` [U-Boot] [PATCH V3 3/5] mmc: sdhci: add mmc structure for host Lei Wen
2011-10-08 13:52     ` Sergei Shtylyov
2011-10-08 14:02       ` Lei Wen
2011-10-08 13:47   ` [U-Boot] [PATCH V3 4/5] mmc: sdhci: add timeout for data transfer Lei Wen
2011-10-08 13:47   ` [U-Boot] [PATCH V3 5/5] mmc: sdhci: fix sdma bug for large file transfer Lei Wen
2011-10-04  6:32 ` [U-Boot] [PATCH V2 1/4] mmc: sdhci: fix cache flush Lei Wen
2011-10-04  6:32 ` [U-Boot] [PATCH V2 2/4] mmc: sdhci: fix build warning Lei Wen
2011-10-04  7:02   ` [U-Boot] [PATCH V2.1 " Lei Wen
2011-10-04  6:32 ` [U-Boot] [PATCH V2 3/4] mmc: sdhci: add mmc structure for host Lei Wen
2011-10-04  6:32 ` [U-Boot] [PATCH V2 4/4] mmc: sdhci: add timeout for data transfer Lei Wen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110031245.41424.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.