From: Don Zickus <dzickus@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, Andi Kleen <andi@firstfloor.org>,
Robert Richter <robert.richter@amd.com>,
ying.huang@intel.com, LKML <linux-kernel@vger.kernel.org>,
paulmck@linux.vnet.ibm.com, avi@redhat.com, jeremy@goop.org
Subject: Re: [V7][PATCH 0/6] x86, nmi: new NMI handling routines
Date: Mon, 3 Oct 2011 11:56:55 -0400 [thread overview]
Message-ID: <20111003155655.GG5795@redhat.com> (raw)
In-Reply-To: <1317657158.20367.30.camel@twins>
On Mon, Oct 03, 2011 at 05:52:38PM +0200, Peter Zijlstra wrote:
>
> Also fixed:
>
> drivers/char/ipmi/ipmi_watchdog.c: In function ‘ipmi_nmi’:
> drivers/char/ipmi/ipmi_watchdog.c:1091: error: ‘NMI_HANDLED’ undeclared (first use in this function)
> drivers/char/ipmi/ipmi_watchdog.c:1091: error: (Each undeclared identifier is reported only once
> drivers/char/ipmi/ipmi_watchdog.c:1091: error: for each function it appears in.)
> drivers/char/ipmi/ipmi_watchdog.c:1096: error: ‘NMI_DONE’ undeclared (first use in this function)
> drivers/char/ipmi/ipmi_watchdog.c: In function ‘check_parms’:
> drivers/char/ipmi/ipmi_watchdog.c:1280: error: implicit declaration of function ‘register_nmi_handler’
> drivers/char/ipmi/ipmi_watchdog.c:1280: error: ‘NMI_UNKNOWN’ undeclared (first use in this function)
> drivers/char/ipmi/ipmi_watchdog.c:1289: error: implicit declaration of function ‘unregister_nmi_handler’
> drivers/char/ipmi/ipmi_watchdog.c: In function ‘ipmi_wdog_init’:
> drivers/char/ipmi/ipmi_watchdog.c:1327: error: ‘NMI_UNKNOWN’ undeclared (first use in this function)
> drivers/char/ipmi/ipmi_watchdog.c: In function ‘ipmi_wdog_exit’:
> drivers/char/ipmi/ipmi_watchdog.c:1348: error: ‘NMI_UNKNOWN’ undeclared (first use in this function)
Wow. Sorry about that. I compiled my changes before I submitted. I guess
next time I should 'make clean' before compiling to catch these.
I suck.
Cheers,
Don
next prev parent reply other threads:[~2011-10-03 15:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 19:06 [V7][PATCH 0/6] x86, nmi: new NMI handling routines Don Zickus
2011-09-30 19:06 ` [V7][PATCH 1/6] x86, nmi: split out nmi from traps.c Don Zickus
2011-09-30 19:06 ` [V7][PATCH 2/6] x86, nmi: create new NMI handler routines Don Zickus
2011-09-30 19:06 ` [V7][PATCH 3/6] x86, nmi: wire up NMI handlers to new routines Don Zickus
2011-09-30 19:06 ` [V7][PATCH 4/6] x86, nmi: add in logic to handle multiple events and unknown NMIs Don Zickus
2011-09-30 19:06 ` [V7][PATCH 5/6] x86, nmi: track NMI usage stats Don Zickus
2011-09-30 19:06 ` [V7][PATCH 6/6] x86, nmi: print out NMI stats in /proc/interrupts Don Zickus
2011-10-03 15:47 ` [V7][PATCH 0/6] x86, nmi: new NMI handling routines Peter Zijlstra
2011-10-03 15:52 ` Peter Zijlstra
2011-10-03 15:56 ` Don Zickus [this message]
2011-10-03 15:59 ` Peter Zijlstra
2011-10-04 15:05 ` Robert Richter
2011-10-04 16:43 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111003155655.GG5795@redhat.com \
--to=dzickus@redhat.com \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.