From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, dsahern@gmail.com
Subject: Re: [PATCH] perf: fix broken number of samples for perf report -n
Date: Mon, 3 Oct 2011 13:25:33 -0300 [thread overview]
Message-ID: <20111003162532.GA24281@ghostprotocols.net> (raw)
In-Reply-To: <20111003093815.GA6393@quad>
Em Mon, Oct 03, 2011 at 11:38:15AM +0200, Stephane Eranian escreveu:
>
> The perf report -n option was broken because it was not reporting
> the correct number of samples depending on the sorting mode. By
> default, samples are sorted by comm,dso,sym. That means that
> samples for the same command (binary) get collapsed.
>
> The hists__collapse_insert_entry() had a bug whereby
> it was aggregating the number of events observed (periods)
> but not the number of samples. Consequently, the number
> of samples reported could be below reality. The percentage
> remained correct because based on the periods.
>
> This patch fixes the problem by also aggregating
> the number of samples. Here is an example:
Eagle eyes, this collapse_resort thing has its issues, been fighting
some last week, making 'perf top' use struct hist_entry, killing code.
Double checking that now, thanks!
- Arnaldo
prev parent reply other threads:[~2011-10-03 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 9:38 [PATCH] perf: fix broken number of samples for perf report -n Stephane Eranian
2011-10-03 16:25 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111003162532.GA24281@ghostprotocols.net \
--to=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.