All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: levinsasha928@gmail.com, linux-kernel@vger.kernel.org,
	rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v2 1/2] virtio-net: Verify page list size before fitting into skb
Date: Mon, 3 Oct 2011 20:42:57 +0200	[thread overview]
Message-ID: <20111003184257.GB22427@redhat.com> (raw)
In-Reply-To: <20111003.141951.1122469843900651595.davem@davemloft.net>

On Mon, Oct 03, 2011 at 02:19:51PM -0400, David Miller wrote:
> From: Sasha Levin <levinsasha928@gmail.com>
> Date: Wed, 28 Sep 2011 17:40:54 +0300
> 
> > This patch verifies that the length of a buffer stored in a linked list
> > of pages is small enough to fit into a skb.
> > 
> > If the size is larger than a max size of a skb, it means that we shouldn't
> > go ahead building skbs anyway since we won't be able to send the buffer as
> > the user requested.
> > 
> > Cc: Rusty Russell <rusty@rustcorp.com.au>
> > Cc: "Michael S. Tsirkin" <mst@redhat.com>
> > Cc: virtualization@lists.linux-foundation.org
> > Cc: netdev@vger.kernel.org
> > Cc: kvm@vger.kernel.org
> > Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> 
> Michael, tell me what's happening with these two virtio-net bug fixes.
> 
> Thanks.

Thanks for the reminder.
They are more enhancements than bugfixes, in that both help debug buggy
hypervisors. So net-next material.
Patch 1 is ok patch 2 would benefit from a slightly clearer comment.

-- 
MST

  reply	other threads:[~2011-10-03 18:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-28 14:40 [PATCH v2 1/2] virtio-net: Verify page list size before fitting into skb Sasha Levin
2011-09-28 14:40 ` [PATCH v2 2/2] virtio-net: Prevent NULL dereference Sasha Levin
2011-10-03 18:40   ` Michael S. Tsirkin
2011-10-05 13:50     ` Sasha Levin
2011-10-05 18:59       ` Michael S. Tsirkin
2011-10-03 19:05   ` Michael S. Tsirkin
2011-10-08  8:40     ` Sasha Levin
2011-10-06 19:41   ` David Miller
2011-10-03 18:19 ` [PATCH v2 1/2] virtio-net: Verify page list size before fitting into skb David Miller
2011-10-03 18:42   ` Michael S. Tsirkin [this message]
2011-10-03 19:04 ` Michael S. Tsirkin
2011-10-05 13:50   ` Sasha Levin
2011-10-05 18:59     ` Michael S. Tsirkin
2011-10-06 19:41 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111003184257.GB22427@redhat.com \
    --to=mst@redhat.com \
    --cc=davem@davemloft.net \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.