From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH 14 of 24] libxl: add pid path to
	libxl__spawner_starting
Date: Tue, 4 Oct 2011 11:09:20 +0200
Message-ID: <20111004090919.GA17264@aepfle.de>
References: <patchbomb.1317657277@probook.site>
	<219ab93f22c049259568.1317657291@probook.site>
	<1317716599.21903.76.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <1317716599.21903.76.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, Oct 04, Ian Campbell wrote:

> On Mon, 2011-10-03 at 16:54 +0100, Olaf Hering wrote:

> > +++ b/tools/libxl/libxl_internal.h
> > @@ -250,6 +250,7 @@ typedef struct {
> >  
> >  typedef struct {
> >      char *dom_path; /* from libxl_malloc, only for libxl_spawner_record_pid */
> > +    char *pid_path; /* from libxl_malloc, only for libxl_spawner_record_pid */
> 
> Either this new comment is true and you need a strdup() up above where
> you set it and a free() somewhere else (or use libxl__strdup()) or it is
> false and it should be removed and pid_path should be const char *.
> 
> I think the second option is sufficient for the current and new user you
> are about to add?

I duplicated the dom_path line without paying attention to the comment.
A const char *pid_path; is sufficient.

Olaf