From: Samuel Ortiz <sameo@linux.intel.com>
To: Todd Poynor <toddpoynor@google.com>
Cc: linux-omap@vger.kernel.org, Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCH 2/2] mfd: twl6030: Disable IRQ during suspend
Date: Tue, 4 Oct 2011 11:57:31 +0200 [thread overview]
Message-ID: <20111004095731.GU4118@sortiz-mobl> (raw)
In-Reply-To: <1317080664-28096-2-git-send-email-toddpoynor@google.com>
Hi Todd,
On Mon, Sep 26, 2011 at 04:44:24PM -0700, Todd Poynor wrote:
> Module IRQs may still be disabled by DPM at the time the TWL6030
> ISR runs, causing handle_simple_irq() to silently do nothing.
> This may result in missing TWL RTC alarm wakeups, for example,
> since the RTC child module ISR is not called to ack the IRQ.
>
> Disable the TWL6030 IRQ during suspend, enable it at DPM resume
> time, at which time the child module IRQs will be re-enabled.
Applied as well, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2011-10-04 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 23:44 [PATCH 1/2] mfd: twl6030: fix lockdep recursion warning on setting wake IRQs Todd Poynor
2011-09-26 23:44 ` [PATCH 2/2] mfd: twl6030: Disable IRQ during suspend Todd Poynor
2011-09-27 5:15 ` Santosh Shilimkar
2011-10-04 9:57 ` Samuel Ortiz [this message]
2011-09-27 5:14 ` [PATCH 1/2] mfd: twl6030: fix lockdep recursion warning on setting wake IRQs Santosh Shilimkar
2011-10-04 9:56 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004095731.GU4118@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.