From: Andrew Morton <akpm00@gmail.com>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: LKML <linux-kernel@vger.kernel.org>,
container ML <containers@lists.linux-foundation.org>,
Paul Menage <paul@paulmenage.org>, Li Zefan <lizf@cn.fujitsu.com>,
Ingo Molnar <mingo@elte.hu>, Miao Xie <miaox@cn.fujitsu.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Tejun Heo <htejun@gmail.com>,
stable@kernel.org
Subject: Re: [BUGFIX] cgroup: create a workqueue for cgroup
Date: Tue, 4 Oct 2011 14:10:16 -0700 [thread overview]
Message-ID: <20111004141016.af26219d.akpm00@gmail.com> (raw)
In-Reply-To: <20111003141911.b4ee7bca.nishimura@mxp.nes.nec.co.jp>
On Mon, 3 Oct 2011 14:19:11 +0900
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
> On Mon, 3 Oct 2011 09:22:44 +0900
> Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
>
> > On Fri, 30 Sep 2011 15:30:49 -0700
> > Andrew Morton <akpm00@gmail.com> wrote:
> >
> > > On Fri, 30 Sep 2011 16:54:52 +0900
> > > Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
> > >
> > > > In commit:f90d4118, cpuset_wq, a separate workqueue for cpuset, was introduced
> > > > to avoid a dead lock against cgroup_mutex between async_rebuild_sched_domains()
> > > > and cgroup_tasks_write().
> > > >
> > > > But check_for_release() has a similar problem:
> > > >
> > > > check_for_release()
> > > > schedule_work(release_agent_work)
> > > > cgroup_release_agent()
> > > > mutex_lock(&cgroup_mutex)
> > > >
> > > > And I actually see a lockup which seems to be caused by this problem
> > > > on 2.6.32-131.0.15.el6.x86_64.
> > >
> > > Are you sure the bug is still present in current kernels? Perhaps
> > > Tejun's workqueue changes magically made it go away.
> > >
> > Not yet, but I'll check it.
> >
> As you said, I cannot repricate this issue on 3.1-rc8. But I've verified
> it happens on 2.6.32.46 and this patch fixes it, so I think this patch is
> necessary for stable at least.
>
Getting the fix into -stable is a problem.
Firstly, the -stable maintainers only really take backports of fixes
which are already in mainline. So to fix this bug one would need to
identify which upstream fix(es) did the work, and backport those.
Secondly, I'm not sure that kernels as old as 2.6.32.x are still being
maintained at kernel.org, at least.
So I'm not sure what to suggest. Perhaps send the fix directly to
distro kernel maintainers?
prev parent reply other threads:[~2011-10-04 21:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 7:54 [BUGFIX] cgroup: create a workqueue for cgroup Daisuke Nishimura
2011-09-30 22:30 ` Andrew Morton
2011-10-03 0:22 ` Daisuke Nishimura
2011-10-03 5:19 ` Daisuke Nishimura
2011-10-04 21:10 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004141016.af26219d.akpm00@gmail.com \
--to=akpm00@gmail.com \
--cc=containers@lists.linux-foundation.org \
--cc=htejun@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=miaox@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=paul@paulmenage.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.