From: Benjamin Marzinski <bmarzins@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@gmail.com>
Subject: [PATCH] multipath: make sure all the hwe attributes get merged
Date: Tue, 4 Oct 2011 23:13:49 -0500 [thread overview]
Message-ID: <20111005041349.GP24133@ether.msp.redhat.com> (raw)
Not all of the hwe attributes were getting merged. Also,
multipathd show config was putting an extra set of quotes around the entries
in the devices section.
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
libmultipath/config.c | 4 ++++
libmultipath/print.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
Index: multipath-tools-110916/libmultipath/config.c
===================================================================
--- multipath-tools-110916.orig/libmultipath/config.c
+++ multipath-tools-110916/libmultipath/config.c
@@ -320,6 +320,10 @@ merge_hwe (struct hwentry * dst, struct
merge_num(no_path_retry);
merge_num(minio);
merge_num(minio_rq);
+ merge_num(pg_timeout);
+ merge_num(flush_on_last_del);
+ merge_num(fast_io_fail);
+ merge_num(dev_loss);
return 0;
}
Index: multipath-tools-110916/libmultipath/print.c
===================================================================
--- multipath-tools-110916.orig/libmultipath/print.c
+++ multipath-tools-110916/libmultipath/print.c
@@ -860,7 +860,7 @@ snprint_hwentry (char * buff, int len, s
if (fwd > len)
return len;
iterate_sub_keywords(rootkw, kw, i) {
- fwd += snprint_keyword(buff + fwd, len - fwd, "\t\t%k \"%v\"\n",
+ fwd += snprint_keyword(buff + fwd, len - fwd, "\t\t%k %v\n",
kw, hwe);
if (fwd > len)
return len;
next reply other threads:[~2011-10-05 4:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 4:13 Benjamin Marzinski [this message]
2011-10-05 20:48 ` [PATCH] multipath: make sure all the hwe attributes get merged Christophe Varoqui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111005041349.GP24133@ether.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=christophe.varoqui@gmail.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.