From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org
Subject: re: ath6kl: pass only unicast frames for aggregation
Date: Wed, 5 Oct 2011 08:59:58 +0300 [thread overview]
Message-ID: <20111005055958.GA32513@elgon.mountain> (raw)
Hi Kalle,
Smatch complains that 5694f962964 "ath6kl: pass only unicast frames
for aggregation"
drivers/net/wireless/ath/ath6kl/txrx.c
1241 if (conn && ar->intra_bss) {
1242 skb1 = skb;
1243 skb = NULL;
^^^^^^^^^^^
1244 } else if (conn && !ar->intra_bss) {
1245 dev_kfree_skb(skb);
1246 skb = NULL;
^^^^^^^^^^^
1247 }
1248 }
1249 if (skb1)
1250 ath6kl_data_tx(skb1, ar->net_dev);
1251 }
1252
1253 datap = (struct ethhdr *) skb->data;
^^^^^^^^^
skb can be NULL.
1254
regards,
dan carpenter
next reply other threads:[~2011-10-05 6:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 5:59 Dan Carpenter [this message]
2011-10-05 10:09 ` ath6kl: pass only unicast frames for aggregation Kalle Valo
2011-10-05 11:57 ` Jouni Malinen
2011-10-06 11:27 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111005055958.GA32513@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.