From: Guenter Roeck <guenter.roeck@ericsson.com>
To: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"Device-drivers-devel@blackfin.uclinux.org"
<Device-drivers-devel@blackfin.uclinux.org>
Subject: Re: [PATCH] staging:iio:adc:ad7314 removal. Supported via hwmon.
Date: Wed, 5 Oct 2011 02:40:09 -0700 [thread overview]
Message-ID: <20111005094009.GA14989@ericsson.com> (raw)
In-Reply-To: <544AC56F16B56944AEC3BD4E3D59177146E7343656@LIMKCMBX1.ad.analog.com>
On Wed, Oct 05, 2011 at 04:39:01AM -0400, Hennerich, Michael wrote:
> Jonathan Cameron wrote on 2011-09-30:
> > Driver ported over to hwmon where it fits much better.
> >
> > Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
>
> Acked-by: Michael Hennerich <michael.hennerich@analog.com>
>
> > ---
> > Technically there is a slight loss of functionality in the hwmon
> > driver (no power down mode).
> >
> > Otherwise, lets clear this one out.
> >
> > 3 more to go on my removal list ;)
> > adt7310, adt7410 and adt75.
> >
Just noticed this part. ADT75 is the Analog version of LM75.
Any reason not to use the standard LM75 driver instead ?
On a side note, the iio adt75 driver won't work properly if oneshot is configured.
I'll leave it to the readers to figure out why ;).
Regarding the power down mode, shouldn't this be supported using the standard
suspend/resume API with CONFIG_PM ? Or does iio have a parallel mechanism ?
Thanks,
Guenter
next prev parent reply other threads:[~2011-10-05 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 10:20 [PATCH] staging:iio:adc:ad7314 removal. Supported via hwmon Jonathan Cameron
2011-10-05 8:39 ` Hennerich, Michael
2011-10-05 9:40 ` Guenter Roeck [this message]
2011-10-05 10:07 ` Jonathan Cameron
2011-10-05 10:29 ` Guenter Roeck
2011-10-05 11:50 ` Hennerich, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111005094009.GA14989@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=Device-drivers-devel@blackfin.uclinux.org \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.