All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Add 'pv' (Pipe-Viewer) to BuildRoot
Date: Thu, 6 Oct 2011 18:30:12 +0200	[thread overview]
Message-ID: <20111006183012.24ff3f7d@skate> (raw)
In-Reply-To: <1317913244.21369.15.camel@roelpc.telenet.be>

Le Thu, 06 Oct 2011 17:00:44 +0200,
Roeland Van Praet <roelvp@mind.be> a ?crit :

> diff -ruN a/package/Config.in b/package/Config.in
> --- a/package/Config.in	2011-10-06 16:47:32.000000000 +0200
> +++ b/package/Config.in	2011-10-06 16:47:47.000000000 +0200
> @@ -31,6 +31,7 @@
>  source "package/strace/Config.in"
>  source "package/whetstone/Config.in"
>  source "package/valgrind/Config.in"
> +source "package/pv/Config.in"
>  endmenu
>  
>  menu "Development tools"
> diff -ruN a/package/pv/Config.in b/package/pv/Config.in
> --- a/package/pv/Config.in	1970-01-01 01:00:00.000000000 +0100
> +++ b/package/pv/Config.in	2011-10-06 15:50:50.000000000 +0200
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_PV
> +	bool "pv"
> +	help
> +	  Pipe Viewer - is a terminal-based tool for
> +          monitoring the progress of data through a
> +          pipeline.

Incorrect indentation for the help text. It should be one tab + two
spaces for each line.

> --- a/package/pv/pv-1.2.0-fixld.patch	1970-01-01 01:00:00.000000000
> +0100
> +++ b/package/pv/pv-1.2.0-fixld.patch	2011-10-06 16:36:28.000000000
> +0200

Each patch must contain a description + Signed-off-by line.

> --- a/package/pv/pv.mk	1970-01-01 01:00:00.000000000 +0100
> +++ b/package/pv/pv.mk	2011-10-06 15:50:50.000000000 +0200
> @@ -0,0 +1,13 @@
> +#######################
> +#
> +# pv - Pipe Viewer
> +#
> +#######################
> +
> +PV_VERSION = 1.2.0
> +PV_SOURCE = pv-$(PV_VERSION).tar.bz2
> +PV_SITE = http://pipeviewer.googlecode.com/files
> +
> +PV_INSTALL_TARGET = YES

Line not needed, this is the default.

> +$(eval $(call AUTOTARGETS,package,pv))

This should now be:

$(eval $(call AUTOTARGETS))

This is a very recent change in Buildroot Git, and the doc has not been
updated yet.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2011-10-06 16:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-06 15:00 [Buildroot] Add 'pv' (Pipe-Viewer) to BuildRoot Roeland Van Praet
2011-10-06 16:30 ` Thomas Petazzoni [this message]
2011-10-06 16:55   ` Roeland Van Praet
2011-10-07  7:04     ` Roeland Van Praet
2011-10-07  8:21       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111006183012.24ff3f7d@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.