From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 0/2] OMAP: Update nr_irqs field in machine descriptors Date: Thu, 6 Oct 2011 12:50:16 -0700 Message-ID: <20111006195016.GM6324@atomide.com> References: <1314215215-18683-1-git-send-email-svenkatr@ti.com> <4E5636CD.4080302@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "S, Venkatraman" Cc: "linux-omap@vger.kernel.org" , "Cousson, Benoit" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-omap@vger.kernel.org KiBTLCBWZW5rYXRyYW1hbiA8c3ZlbmthdHJAdGkuY29tPiBbMTEwODI1IDA3OjIzXToKPiBPbiBU aHUsIEF1ZyAyNSwgMjAxMSBhdCA1OjE5IFBNLCBDb3Vzc29uLCBCZW5vaXQgPGItY291c3NvbkB0 aS5jb20+IHdyb3RlOgo+ID4gSGkgVmVua2F0LAo+ID4KPiA+IE9uIDgvMjQvMjAxMSA5OjQ2IFBN LCBTLCBWZW5rYXRyYW1hbiB3cm90ZToKPiA+Pgo+ID4+IEFzIHBhcnQgb2YgYW4gZWZmb3J0IHRv IGdldCBzaW5nbGUgQVJNIGtlcm5lbCBiaW5hcnkgWzFdLAo+ID4+IG11bHRpcGxlIMKgZGVmaW5p dGlvbnMgb2YgTlJfSVJRUyB1bmRlciB2YXJpb3VzIHBsYXRmb3Jtcwo+ID4+IGhhdmUgdG8gYmUg cmVjb25jaWxlZCBhbmQgYWJzdHJhY3RlZCBhd2F5IGZyb20gY29tbW9uIGNvZGUuCj4gPj4KPiA+ PiBUaGlzIHBhdGNoIHNlcmllcyB0YWtlcyB0aGUgc21hbGwgc3RlcCBvZiBwb3B1bGF0aW5nIHRo ZQo+ID4+IG1hY2hpbmUgZGVzY3JpcHRvcnMgd2l0aCB0aGUgcHJlLWV4aXN0aW5nIG5yX2lycXMg ZmllbGQuCj4gPj4gRXZlbnR1YWxseSwgdGhlIGNvbW1vbiBpcnEgaGFuZGxlciBjb2RlIHdpbGwg b25seSBsb29rIGF0IHRoaXMKPiA+PiBmaWVsZCBhbmQgbm90IHRoZSBjb21waWxlIHRpbWUgY29u c3RhbnQuCj4gPgo+ID4gTm90IHJlbGF0ZWQgdG8gdGhpcyBwYXRjaCwgYnV0IHN0aWxsIG9uIHRo YXQgdG9waWMuIFRoZSBjdXJyZW50IE5SX0lSUVMKPiA+IGRlcGVuZHMgYXMgd2VsbCBvbiBib2Fy ZCBzdHVmZiwgbGlrZSBmb3IgZXhhbXBsZSA6IHRoZSBQaG9lbml4Cj4gPiBJUlFzOlRXTDYwMzBf SVJRX0JBU0UsIFRXTDYwNDBfQ09ERUNfSVJRX0JBU0UuCj4gPiBJcyB0aGVyZSBhIHBsYW4gdG8g Z2V0IHJpZCBvZiB0aGlzIHN0YXRpYyBkZWZpbmVzPwo+ID4KPiAKPiBDdXJyZW50bHksIHRoZSBn b2FsIGlzIHRvIGdldCByaWQgb2YgdGhlIHNpbmdsZXRvbiBuYXR1cmUKPiBvZiBOUl9JUlFTLiBU aGVuIGl0IGp1c3QgYmVjb21lcyBhIHByb3BlcnR5IG9mIHRoZQo+IHBsYXRmb3JtLCBhbmQgdGhl IGFybSBjb21tb24gY29kZSBzaG91bGQgbm90IHNlZSB0aGlzIGRlZmluZS4KPiBUaGlzIGNsZWFu dXAgaGFzIHRvIGJlIGRvbmUgYWNyb3NzIG11bHRpcGxlIFNvQ3MsIG5vdCBqdXN0IE9NQVAuCj4g Cj4gQWZ0ZXIgSSBnZXQgdG8gY29tcGxldGUgc29tZSBtZWFuaW5nZnVsIGNsZWFudXAgb2YgTlJf SVJRUywKPiBJIGNhbiBsb29rIGludG8gdGhlIHN0YXRpYyBkZWZpbmVzIHRoYXQgeW91IG1lbnRp b24uCgpJIHN1Z2dlc3Qgd2Ugd2FpdCBvbiB0aGlzIHBhdGNoIGFzIHRoZSBOUl9JUlFTIHNob3Vs ZCBiZSB0aGUKYm9hcmQgc3BlY2lmaWMgdHJ1ZSBudW1iZXIgb2YgaW50ZXJydXB0cyBpbmNsdWRp bmcgY2hhaW5lZAppbnRlcnJ1cHRzIGZyb20gZXh0ZXJuYWwgZGV2aWNlcyBsaWtlIHR3bC4gU28g anVzdCBzZXR0aW5nCml0IHRvIE5SX0lSUVMgZG9lcyBub3QgaGVscCBtdWNoLiBBbHNvLCB0aGUg Ym9hcmQtKi5jIGZpbGVzCndpbGwgYmUgZ29pbmcgYXdheXMgd2l0aCBkZXZpY2UgdHJlZSBhdCBz b21lIHBvaW50LgoKUmVnYXJkcywKClRvbnkKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 6 Oct 2011 12:50:16 -0700 Subject: [PATCH 0/2] OMAP: Update nr_irqs field in machine descriptors In-Reply-To: References: <1314215215-18683-1-git-send-email-svenkatr@ti.com> <4E5636CD.4080302@ti.com> Message-ID: <20111006195016.GM6324@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * S, Venkatraman [110825 07:23]: > On Thu, Aug 25, 2011 at 5:19 PM, Cousson, Benoit wrote: > > Hi Venkat, > > > > On 8/24/2011 9:46 PM, S, Venkatraman wrote: > >> > >> As part of an effort to get single ARM kernel binary [1], > >> multiple ?definitions of NR_IRQS under various platforms > >> have to be reconciled and abstracted away from common code. > >> > >> This patch series takes the small step of populating the > >> machine descriptors with the pre-existing nr_irqs field. > >> Eventually, the common irq handler code will only look at this > >> field and not the compile time constant. > > > > Not related to this patch, but still on that topic. The current NR_IRQS > > depends as well on board stuff, like for example : the Phoenix > > IRQs:TWL6030_IRQ_BASE, TWL6040_CODEC_IRQ_BASE. > > Is there a plan to get rid of this static defines? > > > > Currently, the goal is to get rid of the singleton nature > of NR_IRQS. Then it just becomes a property of the > platform, and the arm common code should not see this define. > This cleanup has to be done across multiple SoCs, not just OMAP. > > After I get to complete some meaningful cleanup of NR_IRQS, > I can look into the static defines that you mention. I suggest we wait on this patch as the NR_IRQS should be the board specific true number of interrupts including chained interrupts from external devices like twl. So just setting it to NR_IRQS does not help much. Also, the board-*.c files will be going aways with device tree at some point. Regards, Tony