From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] hw_random: add driver for atmel true hardware random number generator
Date: Thu, 6 Oct 2011 22:30:23 +0200 [thread overview]
Message-ID: <20111006203023.GE24034@tarshish> (raw)
In-Reply-To: <1317923791-31200-1-git-send-email-jacmet@sunsite.dk>
Hi Peter,
On Thu, Oct 06, 2011 at 07:56:30PM +0200, Peter Korsgaard wrote:
> For the IP block on 9g45/9g46/9m10/9m11.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
[snip]
> +static int atmel_trng_read(struct hwrng *rng, void *buf, size_t max,
> + bool wait)
> +{
> + struct atmel_trng *trng = container_of(rng, struct atmel_trng, rng);
> + u32 *data = buf;
> +
> + /* data ready? */
> + if (readl(trng->base + TRNG_ODATA) & 1) {
> + *data = readl(trng->base + TRNG_ODATA);
> + return 4;
Shouldn't you check for max >= 4 before writing to *buf?
> + } else
> + return 0;
> +}
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2011-10-06 20:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 17:56 [PATCHv2] hw_random: add driver for atmel true hardware random number generator Peter Korsgaard
2011-10-06 20:30 ` Baruch Siach [this message]
2011-10-06 20:44 ` Peter Korsgaard
2011-10-06 20:52 ` Baruch Siach
2011-10-07 9:21 ` Jamie Iles
2011-10-07 9:53 ` Nicolas Ferre
2011-10-07 18:45 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006203023.GE24034@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.