From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Thu, 06 Oct 2011 23:26:55 +0200
Subject: [U-Boot] [PATCH v14 3/9] nds32/core N1213: NDS32 N12 core
	family N1213
In-Reply-To: <1316574638-20460-3-git-send-email-macpaul@andestech.com>
References: <1316571644-27749-1-git-send-email-macpaul@andestech.com>
	<1316574638-20460-3-git-send-email-macpaul@andestech.com>
Message-ID: <20111006212655.AC7661408751@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Macpaul Lin,

In message <1316574638-20460-3-git-send-email-macpaul@andestech.com> you wrote:
> Add N1213 cpu core (N12 Core family) support for NDS32 arch.
> This patch includes start.S for the initialize procedure of N1213.
> 
> Start procedure:
>  start.S will start up the N1213 CPU core at first,
>  then jump to SoC dependent "lowlevel_init.S" and
>  "watchdog.S" to configure peripheral devices.
> 
> Signed-off-by: Macpaul Lin <macpaul@andestech.com>
> ---
> Changes v1 to v6:
>   - Style clean up and reorganize code
> Changes v7-v9:
>   - No Change.
> Changes v10:
>   - start.S of N1213 CPU has been rewrote for relocation support.
>   - u-boot.lds:
>    - Add got and *(.got.plt) section for support GCC 4 toolchain
>    - Modified for relocation implementation.
> Changes v11:
>   - arch/nds32/cpu/n1213/Makefile
>    - replace $(AR) $(call cmd_link_o_target,...)
> Changes v12:
>   - u-boot.lds
>    - Remove the 0x00000000 base address in linker script.
>      The base address of the binary will be determined by CONFIG_SYS_TEXT_BASE
>   - Remove the CPU features in commit log and add to README in later patches.
> Changes v13-v14:
>   - No change.
> 
>  arch/nds32/cpu/n1213/Makefile   |   50 ++++
>  arch/nds32/cpu/n1213/start.S    |  501 +++++++++++++++++++++++++++++++++++++++
>  arch/nds32/cpu/n1213/u-boot.lds |   70 ++++++
>  3 files changed, 621 insertions(+), 0 deletions(-)
>  create mode 100644 arch/nds32/cpu/n1213/Makefile
>  create mode 100644 arch/nds32/cpu/n1213/start.S
>  create mode 100644 arch/nds32/cpu/n1213/u-boot.lds

Checkpatch says:

total: 0 errors, 7 warnings, 621 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Niklaus Wirth has lamented that, whereas Europeans pronounce his name
correctly  (Ni-klows  Virt),  Americans  invariably  mangle  it  into
(Nick-les  Worth).  Which  is to say that Europeans call him by name,
but Americans call him by value.