From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 09/12] VIDEO: davinci: add framebuffer to da8xx
Date: Fri, 7 Oct 2011 00:14:27 +0200 [thread overview]
Message-ID: <20111007001427.5d578407@wker> (raw)
In-Reply-To: <1317807819-17056-9-git-send-email-sbabic@denx.de>
Hi Stefano,
On Wed, 5 Oct 2011 11:43:36 +0200
Stefano Babic <sbabic@denx.de> wrote:
> The patch is a port of the Linux driver da8xx-fb.c used
> on davinci da8xx and OMAP-L138 boards.
>
> Last commit seen on this driver used as base
> for porting is 1db41e032d563eb47deab40dc5595be306b143ba
> (video: da8xx-fb: fix section mismatch warning)
>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> CC: Sandeep Paulraj <s-paulraj@ti.com>
> Cc: Anatolij Gustschin <agust@denx.de>
> ---
> arch/arm/include/asm/arch-davinci/da8xx-fb.h | 122 ++++
> drivers/video/Makefile | 1 +
> drivers/video/da8xx-fb.c | 846 ++++++++++++++++++++++++++
> 3 files changed, 969 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/include/asm/arch-davinci/da8xx-fb.h
> create mode 100644 drivers/video/da8xx-fb.c
>
> diff --git a/arch/arm/include/asm/arch-davinci/da8xx-fb.h b/arch/arm/include/asm/arch-davinci/da8xx-fb.h
> new file mode 100644
> index 0000000..88613a5
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-davinci/da8xx-fb.h
> @@ -0,0 +1,122 @@
> +/*
> + * Header file for TI DA8XX LCD controller platform data.
> + *
> + * Copyright (C) 2008-2009 MontaVista Software Inc.
> + * Copyright (C) 2008-2009 Texas Instruments Inc
> + *
> + * This file is licensed under the terms of the GNU General Public License
> + * version 2. This program is licensed "as is" without any warranty of any
> + * kind, whether express or implied.
> + */
Hmm, the whole driver is under GPL v2 or any later version, but this
header under GPL v2 only? Actually this doesn't make sense. Newly added
code should use GPLv3-compatible licensing, e.g. GPL v2 or any later version.
...
> +#if 0
> +/* ioctls */
> +#define FBIOGET_CONTRAST _IOR('F', 1, int)
> +#define FBIOPUT_CONTRAST _IOW('F', 2, int)
> +#define FBIGET_BRIGHTNESS _IOR('F', 3, int)
> +#define FBIPUT_BRIGHTNESS _IOW('F', 3, int)
> +#define FBIGET_COLOR _IOR('F', 5, int)
> +#define FBIPUT_COLOR _IOW('F', 6, int)
> +#define FBIPUT_HSYNC _IOW('F', 9, int)
> +#define FBIPUT_VSYNC _IOW('F', 10, int)
> +#endif
Please do not add dead code.
Thanks,
Anatolij
next prev parent reply other threads:[~2011-10-06 22:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 9:43 [U-Boot] [PATCH 01/12] Davinci: ea20: set console on UART0 Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 02/12] Davinci: ea20: set GPIOs to hold MII-Phy in reset and set UART0-Switch for console Stefano Babic
2011-10-05 12:06 ` Laurence Withers
2011-10-05 13:00 ` Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 03/12] Davinci: ea20: Add NAND support Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 04/12] Davinci: ea20: Add early init to get early output from console Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 05/12] Davinci: ea20: Add default U-Boot environment Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 06/12] Davinci: ea20: add gpio for keeping power on in board_late_init Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 07/12] Davinci: ea20: add gpios for LCD backlight control Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 08/12] ARM: Davinci: added missing registers to hardware.h Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 09/12] VIDEO: davinci: add framebuffer to da8xx Stefano Babic
2011-10-06 22:14 ` Anatolij Gustschin [this message]
2011-10-06 22:22 ` stefano babic
2011-10-06 22:32 ` Wolfgang Denk
2011-10-06 22:44 ` stefano babic
2011-10-07 4:42 ` Wolfgang Denk
2011-10-05 9:43 ` [U-Boot] [PATCH 10/12] Davinci: ea20: added video support Stefano Babic
2011-10-06 21:12 ` Anatolij Gustschin
2011-10-05 9:43 ` [U-Boot] [PATCH 11/12] Davinci: ea20: added I2C support Stefano Babic
2011-10-05 9:43 ` [U-Boot] [PATCH 12/12] Davinci: ea20: added PREBOOT to configuration Stefano Babic
2011-10-05 13:08 ` [U-Boot] [PATCH 13/13] Davinci: ea20: use gpio framework to access gpios Stefano Babic
2011-10-05 13:14 ` Laurence Withers
2011-10-05 13:49 ` Stefano Babic
2011-10-08 9:27 ` [U-Boot] [PATCH V2 09/12] VIDEO: davinci: add framebuffer to da8xx Stefano Babic
2011-10-11 16:10 ` Anatolij Gustschin
2011-10-12 8:42 ` Stefano Babic
2011-10-12 9:06 ` Anatolij Gustschin
2011-10-12 9:35 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111007001427.5d578407@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.