From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 7/9] xfs: clean up xfs_ioerror_alert
Date: Fri, 7 Oct 2011 12:54:41 +1100 [thread overview]
Message-ID: <20111007015441.GD3159@dastard> (raw)
In-Reply-To: <20111006210639.731475087@bombadil.infradead.org>
On Thu, Oct 06, 2011 at 05:06:14PM -0400, Christoph Hellwig wrote:
> Instead of passing the block number and mount structure explicitly
> get them off the bp and fix make the argument order more natural.
>
> Also move it to xfs_buf.c and stop printing the device name given
> that we already get the fs name as part of xfs_alert, and we know
> what device is operates on because of the caller that gets printed.
>
Only thing I'm wondering about is whether is should be renamed
xfs_buf_ioerror_alert(), now that it really is a xfs_buf specific
function?
Also, many of the callers could probably pass __func__ rather than a
manually set string...
Otherwise, another nice cleanup.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-10-07 2:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 21:06 [PATCH 0/9] a couple of buffer cache cleanups Christoph Hellwig
2011-10-06 21:06 ` [PATCH 1/9] xfs: remove xfs_get_buftarg_list Christoph Hellwig
2011-10-07 1:38 ` Dave Chinner
2011-10-07 19:36 ` Alex Elder
2011-10-06 21:06 ` [PATCH 2/9] xfs: remove XFS_BUF_FINISH_IOWAIT Christoph Hellwig
2011-10-07 1:38 ` Dave Chinner
2011-10-07 19:36 ` Alex Elder
2011-10-06 21:06 ` [PATCH 3/9] xfs: remove XFS_BUF_SET_VTYPE and XFS_BUF_SET_VTYPE_REF Christoph Hellwig
2011-10-07 1:40 ` Dave Chinner
2011-10-07 19:36 ` Alex Elder
2011-10-06 21:06 ` [PATCH 4/9] xfs: remove XFS_BUF_STALE and XFS_BUF_SUPER_STALE Christoph Hellwig
2011-10-07 1:41 ` Dave Chinner
2011-10-07 19:36 ` Alex Elder
2011-10-06 21:06 ` [PATCH 5/9] xfs: remove buffers from the delwri list in xfs_buf_stale Christoph Hellwig
2011-10-07 1:45 ` Dave Chinner
2011-10-07 19:36 ` Alex Elder
2011-10-06 21:06 ` [PATCH 6/9] xfs: clean up buffer allocation Christoph Hellwig
2011-10-07 1:48 ` Dave Chinner
2011-10-07 19:37 ` Alex Elder
2011-10-06 21:06 ` [PATCH 7/9] xfs: clean up xfs_ioerror_alert Christoph Hellwig
2011-10-07 1:54 ` Dave Chinner [this message]
2011-10-07 14:17 ` Christoph Hellwig
2011-10-07 19:37 ` Alex Elder
2011-10-06 21:06 ` [PATCH 8/9] xfs: use xfs_ioerror_alert in xfs_buf_iodone_callbacks Christoph Hellwig
2011-10-07 1:55 ` Dave Chinner
2011-10-07 19:37 ` Alex Elder
2011-10-06 21:06 ` [PATCH 9/9] xfs: remove xfs_buf_target_name Christoph Hellwig
2011-10-07 1:57 ` Dave Chinner
2011-10-07 19:37 ` Alex Elder
2011-10-07 20:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111007015441.GD3159@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.