From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Eugeni Dodonov <eugeni@dodonov.net>
Cc: intel-gfx@lists.freedesktop.org,
Eugeni Dodonov <eugeni.dodonov@intel.com>
Subject: Re: [PATCH 1/2] Give up on edid retries when i2c tells us that bus is not there
Date: Fri, 7 Oct 2011 07:08:37 -0700 [thread overview]
Message-ID: <20111007070837.45d8ac60@jbarnes-e6510> (raw)
In-Reply-To: <1317943836-7362-2-git-send-email-eugeni@dodonov.net>
On Thu, 6 Oct 2011 20:30:35 -0300
Eugeni Dodonov <eugeni@dodonov.net> wrote:
> From: Eugeni Dodonov <eugeni.dodonov@intel.com>
>
> This allows to avoid talking to a non-existent bus repeatedly until we
> finally timeout. The non-existent bus is signalled by -ENXIO error,
> provided by i2c_algo_bit:bit_doAddress call.
>
> As the advantage of such change, all the other routines which use
> drm_get_edid would benefit for this timeout.
>
> As the disadvantage comes the fact that I only tested it on Intel
> cards, so I am not sure whether it would work on nouveau and radeon.
>
> This change should potentially fix
> https://bugs.freedesktop.org/show_bug.cgi?id=41059
I think I like this, assuming i2c doesn't lie to us. But won't we spam
the log quite a bit? We do detection a lot because userspace often
polls it and performs detection at app startup a lot.
Jesse
next prev parent reply other threads:[~2011-10-07 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 23:30 [PATCH 0/2] RFC: Potential improvements in edid detection timings Eugeni Dodonov
2011-10-06 23:30 ` [PATCH 1/2] Give up on edid retries when i2c tells us that bus is not there Eugeni Dodonov
2011-10-07 14:08 ` Jesse Barnes [this message]
2011-10-07 14:11 ` Eugeni Dodonov
2011-10-06 23:30 ` [PATCH 2/2] Check if the bus is valid prior to discovering edid Eugeni Dodonov
-- strict thread matches above, loose matches on Subject: below --
2011-10-07 22:00 [PATCH 0/2] RFC: Potential improvements in edid detection timings (v2) Eugeni Dodonov
2011-10-07 22:00 ` [PATCH 1/2] Give up on edid retries when i2c tells us that bus is not there Eugeni Dodonov
2011-10-17 13:12 [PATCH] Improvements in edid detection timings (final) Eugeni Dodonov
2011-10-17 13:12 ` [PATCH 1/2] Give up on edid retries when i2c tells us that bus is not there Eugeni Dodonov
2011-10-17 20:41 ` Keith Packard
2011-10-17 21:07 ` Eugeni Dodonov
2011-10-17 22:41 ` Keith Packard
2011-10-18 0:06 ` Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111007070837.45d8ac60@jbarnes-e6510 \
--to=jbarnes@virtuousgeek.org \
--cc=eugeni.dodonov@intel.com \
--cc=eugeni@dodonov.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.