From: Sascha Hauer <s.hauer@pengutronix.de>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [RFC/PATCH 0/2] Backlight support
Date: Fri, 7 Oct 2011 15:15:08 +0200 [thread overview]
Message-ID: <20111007131508.GD31404@pengutronix.de> (raw)
In-Reply-To: <4E8D6133.8080604@free-electrons.com>
Hi Gregory,
On Thu, Oct 06, 2011 at 10:05:07AM +0200, Gregory CLEMENT wrote:
> This patch set is a RFC about a backlight framework. The purpose of
> this framework is mainly to allow to add easily a support for a
> backlight with the possibility of setting brightness directly from the
> barebox shell using the brightness parameter.
>
> An implementation is provided for i.MX23 by using the PWM. It was
> tested on a custom i.MX23 base board.
Two things that bother me in this series.
First thing is that I wonder if it would be better to not
register a seperate device for backlight. How about a call
like this:
fb_register_backlight(const char *fb,
void (*set_brightness)(int brightness, void *priv));
The core would only need a function to find the struct device_d
by the corresponding "fbx" string. This way we could add the
brightness variable to the framebuffer and not a seperate device,
so fb0.brightness=50.
The second thing is that the pwm you use for the mxs backlight
is a generic pwm which not necessarily drives a backlight. We
should have a generic pwm api for this. Otherwise we end up
with different drivers for the same pwm.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-10-07 13:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 8:05 [RFC/PATCH 0/2] Backlight support Gregory CLEMENT
2011-10-07 13:15 ` Sascha Hauer [this message]
2011-10-07 20:47 ` Gregory CLEMENT
2011-10-08 12:47 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111007131508.GD31404@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=gregory.clement@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.