From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mvgbe: fix network device indices
Date: Fri, 7 Oct 2011 13:16:24 -0400 [thread overview]
Message-ID: <201110071316.25219.vapier@gentoo.org> (raw)
In-Reply-To: <1317939802-19695-1-git-send-email-michael@walle.cc>
On Thursday 06 October 2011 18:23:22 Michael Walle wrote:
> --- a/net/eth.c
> +++ b/net/eth.c
>
> +int eth_setenv_enetaddr_by_index(const char *base_name, int index,
> + const uchar *enetaddr)
> +{
> + char enetvar[32];
> + sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index);
> + return eth_setenv_enetaddr(enetvar, enetaddr);
> +}
please unify the duplicate logic coming from eth_getenv_enetaddr_by_index in a
new local static function
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111007/9420fe8d/attachment.pgp
next prev parent reply other threads:[~2011-10-07 17:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 22:23 [U-Boot] [PATCH] mvgbe: fix network device indices Michael Walle
2011-10-07 8:26 ` Prafulla Wadaskar
2011-10-07 10:48 ` Michael Walle
2011-10-16 18:28 ` Michael Walle
2011-10-07 17:16 ` Mike Frysinger [this message]
2011-10-21 8:09 ` Prafulla Wadaskar
2011-10-25 21:10 ` Michael Walle
2011-10-27 9:12 ` Prafulla Wadaskar
2011-10-27 10:22 ` Michael Walle
2011-10-27 21:31 ` [U-Boot] [PATCH 0/2] improve ethernet device index handling Michael Walle
2011-10-27 21:31 ` [U-Boot] [PATCH 1/2] net: introduce per device index Michael Walle
2011-10-27 21:36 ` Michael Walle
2011-11-03 11:23 ` Michael Walle
2011-11-03 11:39 ` Prafulla Wadaskar
2011-11-03 17:58 ` Wolfgang Denk
2011-11-03 18:09 ` Mike Frysinger
2011-10-27 21:31 ` [U-Boot] [PATCH 2/2] mvgbe: fix network device indices Michael Walle
2011-11-03 18:10 ` Mike Frysinger
2011-11-03 23:02 ` Michael Walle
2011-11-03 23:11 ` Mike Frysinger
2011-11-04 6:29 ` Prafulla Wadaskar
2011-11-04 23:06 ` Mike Frysinger
2011-11-05 9:53 ` Albert ARIBAUD
2011-11-05 13:21 ` Wolfgang Denk
2011-11-05 14:34 ` Albert ARIBAUD
2011-11-05 15:06 ` Wolfgang Denk
2011-11-08 7:44 ` Prafulla Wadaskar
2011-11-08 7:32 ` Prafulla Wadaskar
2011-11-08 13:56 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110071316.25219.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.