From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470Ab1JJHGc (ORCPT ); Mon, 10 Oct 2011 03:06:32 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:36935 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884Ab1JJHGb (ORCPT ); Mon, 10 Oct 2011 03:06:31 -0400 Date: Mon, 10 Oct 2011 09:04:43 +0200 From: Ingo Molnar To: Masami Hiramatsu Cc: Peter Zijlstra , Stephane Eranian , Andi Kleen , linux-kernel@vger.kernel.org, acme@redhat.com, ming.m.lin@intel.com, robert.richter@amd.com, ravitillo@lbl.gov, yrl.pp-manager.tt@hitachi.com, Thomas Gleixner , "H. Peter Anvin" , Srikar Dronamraju Subject: Re: [PATCH] x86: Fix insn decoder for longer instruction Message-ID: <20111010070443.GN32173@elte.hu> References: <4E8EE885.9040703@hitachi.com> <20111007133155.10933.58577.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111007133155.10933.58577.stgit@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=AWL,BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 AWL AWL: From: address is in the auto white-list Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Masami Hiramatsu wrote: > Fix x86 insn decoder for hardening against invalid length > instructions. This adds length checkings for each byte-read > site and if it exceeds MAX_INSN_SIZE, returns immediately. > This can happen when decoding user-space binary. > > Caller can check whether it happened by checking insn.*.got > member is set or not. Thanks. We really need the /dev/urandom based build-time tester as well. Thanks, Ingo