From: Samuel Ortiz <sameo@linux.intel.com>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Mattias Nilsson <mattias.i.nilsson@stericsson.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 09/23] mfd/db8500-prcmu: tweak for modem wakeup
Date: Mon, 10 Oct 2011 12:31:19 +0200 [thread overview]
Message-ID: <20111010103119.GA12134@sortiz-mobl> (raw)
In-Reply-To: <20111003155207.GP4118@sortiz-mobl>
Hi Linus,
On Mon, Oct 03, 2011 at 05:52:07PM +0200, Samuel Ortiz wrote:
> Hi Linus,
>
> On Fri, Aug 12, 2011 at 10:28:43AM +0200, Linus Walleij wrote:
> > @@ -1754,11 +1755,34 @@ void prcmu_ac_wake_req(void)
> >
> > atomic_set(&ac_wake_req_state, 1);
> >
> > +retry:
> > writel((val | PRCM_HOSTACCESS_REQ_HOSTACCESS_REQ), PRCM_HOSTACCESS_REQ);
> >
> > if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work,
> > - msecs_to_jiffies(20000))) {
> > - pr_err("prcmu: %s timed out (20 s) waiting for a reply.\n",
> > + msecs_to_jiffies(5000))) {
> > + panic("prcmu: %s timed out (5 s) waiting for a reply.\n",
> > + __func__);
> panic(), really ?
What about this one. Do we really want to panic here ?
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2011-10-10 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 8:28 [PATCH 09/23] mfd/db8500-prcmu: tweak for modem wakeup Linus Walleij
2011-10-03 15:52 ` Samuel Ortiz
2011-10-10 10:31 ` Samuel Ortiz [this message]
2011-10-10 11:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010103119.GA12134@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mattias.i.nilsson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.