From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] add package tango-icon-theme and dependency icon-naming-utils
Date: Mon, 10 Oct 2011 16:10:08 +0200 [thread overview]
Message-ID: <20111010161008.3ba4b436@skate> (raw)
In-Reply-To: <1318253496-23729-1-git-send-email-schwarzkopf@sensortherm.de>
Hello Klaus,
Le Mon, 10 Oct 2011 15:31:36 +0200,
Klaus Schwarzkopf <schwarzkopf@sensortherm.de> a ?crit :
> Signed-off-by: Klaus Schwarzkopf <schwarzkopf@sensortherm.de>
> ---
> package/Config.in | 1 +
> package/icon-naming-utils/icon-naming-utils.mk | 11 +++++++++++
> package/tango-icon-theme/Config.in | 6 ++++++
> package/tango-icon-theme/tango-icon-theme.mk | 15 +++++++++++++++
We usually have one patch per new package.
> +$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))
This should be:
$(eval $(call AUTOTARGETS))
in the Git version of Buildroot. The documentation has not yet been
updated in that regard.
> +TANGO_ICON_THEME_VERSION = 0.8.90
> +TANGO_ICON_THEME_SOURCE = tango-icon-theme-$(TANGO_ICON_THEME_VERSION).tar.gz
> +TANGO_ICON_THEME_SITE = http://tango.freedesktop.org/releases/
> +
> +TANGO_ICON_THEME_CONF_ENV = PKG_CONFIG_PATH=$(HOST_DIR)/usr/lib/pkgconfig
Here you're going to build a target package (tango-icon-theme) based on
library informations of the host. This looks wrong. pkg-config already
looks in $(STAGING_DIR)/usr/lib/pkgconfig.
Could you detail why this is needed ?
> +$(eval $(call AUTOTARGETS,package,tango-icon-theme))
$(eval $(call AUTOTARGETS))
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-10-10 14:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 13:31 [Buildroot] [PATCH] add package tango-icon-theme and dependency icon-naming-utils Klaus Schwarzkopf
2011-10-10 14:10 ` Thomas Petazzoni [this message]
2011-10-10 14:23 ` Klaus Schwarzkopf
2011-10-10 17:32 ` Klaus Schwarzkopf
2011-10-10 17:38 ` Thomas Petazzoni
2011-10-10 18:09 ` Klaus Schwarzkopf
2011-10-10 18:07 ` [Buildroot] [PATCH 1/2 v2] add package tango-icon-theme Klaus Schwarzkopf
2011-10-10 18:08 ` [Buildroot] [PATCH 2/2 v2] icon-naming-utils for tango-icon-theme Klaus Schwarzkopf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010161008.3ba4b436@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.