All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] USB: Rework usb_kbd.c
Date: Mon, 10 Oct 2011 20:33:47 +0200	[thread overview]
Message-ID: <201110102033.47223.marek.vasut@gmail.com> (raw)
In-Reply-To: <201110101424.49887.vapier@gentoo.org>

On Monday, October 10, 2011 08:24:48 PM Mike Frysinger wrote:
> On Monday 10 October 2011 11:34:26 Marek Vasut wrote:
> > --- a/common/usb_kbd.c
> > +++ b/common/usb_kbd.c
> > 
> > -#undef USB_KBD_DEBUG
> > +#ifdef	USB_KBD_DEBUG
> > +#define USB_KBD_PRINTF(fmt, args...)	printf(fmt, ##args)
> > +#else
> > +#define USB_KBD_PRINTF(fmt, args...)
> > +#endif
> 
> could we possibly just get rid of USB_KBD_PRINTF() altogether ?  delete
> this chunk and convert everything else to debug() ?
> -mike

I'll squash all these in the subsequence "gcc4.6, rework debug()" macro patch.

  reply	other threads:[~2011-10-10 18:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-10 15:34 [U-Boot] [PATCH 0/3] USB keyboard driver rework (round 2) Marek Vasut
2011-10-10 15:34 ` [U-Boot] [PATCH 1/3] USB: Squash checkpatch warnings in usb_kbd.c Marek Vasut
2011-10-10 18:23   ` Mike Frysinger
2011-12-09  9:29   ` Wolfgang Denk
2011-12-09 11:11     ` [U-Boot] [PATCH] common/usb_kbd.c: fix bug introduced in commit 00b7d6e Wolfgang Denk
2011-12-10 22:07       ` Wolfgang Denk
2011-10-10 15:34 ` [U-Boot] [PATCH 2/3] USB: Rework usb_kbd.c Marek Vasut
2011-10-10 18:24   ` Mike Frysinger
2011-10-10 18:33     ` Marek Vasut [this message]
2011-10-10 18:45       ` Mike Frysinger
2011-10-14 15:50         ` Marek Vasut
2011-10-10 15:34 ` [U-Boot] [PATCH 3/3] USB: Drop dead code from usb_kbd.c Marek Vasut
2011-10-10 18:25   ` Mike Frysinger
2011-11-26 21:52 ` [U-Boot] [PATCH 0/3] USB keyboard driver rework (round 2) Remy Bohmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110102033.47223.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.