From: Benjamin Marzinski <bmarzins@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@gmail.com>
Subject: [PATCH] multipath: set ACT_RESIZE when the size has changed
Date: Mon, 10 Oct 2011 22:19:13 -0500 [thread overview]
Message-ID: <20111011031913.GV24133@ether.msp.redhat.com> (raw)
When the multipath path devices change size, multipath can't be reloaded
with noflush set. So, don't set the action to ACT_RELOAD, which will
cause the multipath device to get stuck in SUSPEND. Use ACT_RESIZE.
Also, I was seeing some messages that were getting cut off with the
128 byte messages size, so I doubled that, and the log area size.
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
libmultipath/configure.c | 4 ++--
libmultipath/log.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
Index: multipath-tools-111010/libmultipath/configure.c
===================================================================
--- multipath-tools-111010.orig/libmultipath/configure.c
+++ multipath-tools-111010/libmultipath/configure.c
@@ -193,8 +193,8 @@ select_action (struct multipath * mpp, v
return;
}
if (cmpp->size != mpp->size) {
- mpp->action = ACT_RELOAD;
- condlog(3, "%s: set ACT_RELOAD (size change)",
+ mpp->action = ACT_RESIZE;
+ condlog(3, "%s: set ACT_RESIZE (size change)",
mpp->alias);
return;
}
Index: multipath-tools-111010/libmultipath/log.h
===================================================================
--- multipath-tools-111010.orig/libmultipath/log.h
+++ multipath-tools-111010/libmultipath/log.h
@@ -1,8 +1,8 @@
#ifndef LOG_H
#define LOG_H
-#define DEFAULT_AREA_SIZE 8192
-#define MAX_MSG_SIZE 128
+#define DEFAULT_AREA_SIZE 16384
+#define MAX_MSG_SIZE 256
#ifndef LOGLEVEL
#define LOGLEVEL 5
reply other threads:[~2011-10-11 3:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011031913.GV24133@ether.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=christophe.varoqui@gmail.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.