From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.17.9]:65410 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753496Ab1JKORy (ORCPT ); Tue, 11 Oct 2011 10:17:54 -0400 From: Arnd Bergmann To: Mark Brown Subject: Re: [PATCH 4/9] ARM: SPMP8000: Add ADC driver Date: Tue, 11 Oct 2011 16:17:51 +0200 Cc: Zoltan Devai , Jonathan Cameron , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org References: <1318178172-7965-1-git-send-email-zoss@devai.org> <20111010114407.GD3607@opensource.wolfsonmicro.com> In-Reply-To: <20111010114407.GD3607@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Message-Id: <201110111617.52061.arnd@arndb.de> Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Monday 10 October 2011, Mark Brown wrote: > On Mon, Oct 10, 2011 at 01:42:30PM +0200, Zoltan Devai wrote: > > > Where should the adc driver go in this case ? > > At the minute it seems to me that arch/arm is as good a place as any > really - currently this code is getting dumped wherever the main device > is. My feeling is that there is a general class of drivers involving the gpio, pinmux, pwm, led, adc and dac: these are basically all things you do with a single pin. Right now we have subsystems for some of them, adding some others and don't have anything for adc basides iio (which only partially fits here). Since there is no externally visible interface for this kind of adc driver, we can always fix it later, which helps a lot. How about putting it into drivers/adc or drivers/misc/adc for now and waiting for others to join it? We can then later make it a proper subsystem along the lines of gpio and pwm and move interfaces for input, hwmon and iio into the subsystem. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 11 Oct 2011 16:17:51 +0200 Subject: [PATCH 4/9] ARM: SPMP8000: Add ADC driver In-Reply-To: <20111010114407.GD3607@opensource.wolfsonmicro.com> References: <1318178172-7965-1-git-send-email-zoss@devai.org> <20111010114407.GD3607@opensource.wolfsonmicro.com> Message-ID: <201110111617.52061.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 10 October 2011, Mark Brown wrote: > On Mon, Oct 10, 2011 at 01:42:30PM +0200, Zoltan Devai wrote: > > > Where should the adc driver go in this case ? > > At the minute it seems to me that arch/arm is as good a place as any > really - currently this code is getting dumped wherever the main device > is. My feeling is that there is a general class of drivers involving the gpio, pinmux, pwm, led, adc and dac: these are basically all things you do with a single pin. Right now we have subsystems for some of them, adding some others and don't have anything for adc basides iio (which only partially fits here). Since there is no externally visible interface for this kind of adc driver, we can always fix it later, which helps a lot. How about putting it into drivers/adc or drivers/misc/adc for now and waiting for others to join it? We can then later make it a proper subsystem along the lines of gpio and pwm and move interfaces for input, hwmon and iio into the subsystem. Arnd