All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: stefanb@linux.vnet.ibm.com, qemu-devel@nongnu.org
Cc: mst@redhat.com, andreas.niederl@iaik.tugraz.at, serge@hallyn.com
Subject: [Qemu-devel] [PATCH V12 7/8] Move parsing of filedescriptor into common function
Date: Tue, 11 Oct 2011 13:32:23 -0400	[thread overview]
Message-ID: <20111011173307.151325846@linux.vnet.ibm.com> (raw)
In-Reply-To: 20111011173216.247822737@linux.vnet.ibm.com

[-- Attachment #1: qemu_parse_fd.diff --]
[-- Type: text/plain, Size: 1721 bytes --]

Move the parsing of a filedescriptor into a common function qemu_parse_fd().
Have the code in net.c call this function.

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

---
 cutils.c      |   12 ++++++++++++
 net.c         |    7 +------
 qemu-common.h |    1 +
 3 files changed, 14 insertions(+), 6 deletions(-)

Index: qemu-git.pt/net.c
===================================================================
--- qemu-git.pt.orig/net.c
+++ qemu-git.pt/net.c
@@ -733,12 +733,7 @@ int net_handle_fd_param(Monitor *mon, co
             return -1;
         }
     } else {
-        char *endptr = NULL;
-
-        fd = strtol(param, &endptr, 10);
-        if (*endptr || (fd == 0 && param == endptr)) {
-            return -1;
-        }
+        fd = qemu_parse_fd(param);
     }
 
     return fd;
Index: qemu-git.pt/qemu-common.h
===================================================================
--- qemu-git.pt.orig/qemu-common.h
+++ qemu-git.pt/qemu-common.h
@@ -143,6 +143,7 @@ time_t mktimegm(struct tm *tm);
 int qemu_fls(int i);
 int qemu_fdatasync(int fd);
 int fcntl_setfl(int fd, int flag);
+int qemu_parse_fd(const char *param);
 
 /*
  * strtosz() suffixes used to specify the default treatment of an
Index: qemu-git.pt/cutils.c
===================================================================
--- qemu-git.pt.orig/cutils.c
+++ qemu-git.pt/cutils.c
@@ -415,3 +415,15 @@ int64_t strtosz(const char *nptr, char *
 {
     return strtosz_suffix(nptr, end, STRTOSZ_DEFSUFFIX_MB);
 }
+
+int qemu_parse_fd(const char *param)
+{
+    int fd;
+    char *endptr = NULL;
+
+    fd = strtol(param, &endptr, 10);
+    if (*endptr || (fd == 0 && param == endptr)) {
+        return -1;
+    }
+    return fd;
+}

  parent reply	other threads:[~2011-10-11 17:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-11 17:32 [Qemu-devel] [PATCH V12 0/8] Qemu Trusted Platform Module (TPM) integration Stefan Berger
2011-10-11 17:32 ` [Qemu-devel] [PATCH V12 1/8] Support for TPM command line options Stefan Berger
2011-12-12 16:01   ` Anthony Liguori
2011-10-11 17:32 ` [Qemu-devel] [PATCH V12 2/8] Add TPM (frontend) hardware interface (TPM TIS) to Qemu Stefan Berger
2011-10-11 17:32 ` [Qemu-devel] [PATCH V12 3/8] Add a debug register Stefan Berger
2011-10-11 17:32 ` [Qemu-devel] [PATCH V12 4/8] Build the TPM frontend code Stefan Berger
2011-10-11 17:32 ` [Qemu-devel] [PATCH V12 5/8] Add a TPM Passthrough backend driver implementation Stefan Berger
2011-10-11 17:32 ` [Qemu-devel] [PATCH V12 6/8] Introduce --enable-tpm-passthrough configure option Stefan Berger
2011-10-11 17:32 ` Stefan Berger [this message]
2011-10-11 17:32 ` [Qemu-devel] [PATCH V12 8/8] Add fd parameter for TPM passthrough driver Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111011173307.151325846@linux.vnet.ibm.com \
    --to=stefanb@linux.vnet.ibm.com \
    --cc=andreas.niederl@iaik.tugraz.at \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.