From: Greg KH <gregkh@suse.de>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Greg KH <greg@kroah.com>, Benjamin LaHaise <bcrl@kvack.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
stable-review@kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
Jon Mason <mason@myri.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [01/38] PCI: Set PCI-E Max Payload Size on fabric
Date: Tue, 11 Oct 2011 15:32:04 -0600 [thread overview]
Message-ID: <20111011213204.GB3881@suse.de> (raw)
In-Reply-To: <CAErSpo7pVC2DxVDmE-oJm6KmaVbWKi2OdCiSastoGQdfMgg+Kg@mail.gmail.com>
On Tue, Oct 11, 2011 at 02:22:11PM -0600, Bjorn Helgaas wrote:
> On Tue, Oct 11, 2011 at 1:56 PM, Greg KH <greg@kroah.com> wrote:
> > On Tue, Oct 11, 2011 at 01:47:47PM -0600, Bjorn Helgaas wrote:
> >> On Tue, Oct 11, 2011 at 1:24 PM, Greg KH <greg@kroah.com> wrote:
> >> > On Tue, Oct 11, 2011 at 12:14:05PM -0600, Bjorn Helgaas wrote:
> >>
> >> >> It's not obvious that this fits the criteria for -stable
> >> >> (Documentation/stable_kernel_rules.txt).
> >> >>
> >> >> For example, I can't tell what real problem this fixes.
> >> >
> >> > Yeah, it's not obvious, but I have had a lot of reports that 3.0 does
> >> > not work on some systems without this set of patches. Now figuring out
> >> > of those same systems ever worked at all is getting to be quite
> >> > difficult as I don't have access to the hardware, and the people that do
> >> > aren't responding to test requests. But from what I gather, 2.6.32 did
> >> > work on these boxes, so it is a regression somehow, but I am not
> >> > positive of this.
> >>
> >> I'd like to know more about this regression.
> >
> > It shows up as an oops that prevents the machine from booting.
> >
> >> > Now I'm very open to pushback, and if people really don't want these in
> >> > (i.e. the PCI maintainer(s) say no), then I'll drop them and work with
> >> > the distros to get them into their trees so that their customers's
> >> > systems will work properly.
> >>
> >> If distros want these patches, does that mean they have bug reports?
> >> URLs to them would be helpful.
> >
> > All of the ones I have are "private" at the moment due to the hardware
> > and product being tested by the users, sorry.
> >
> > I really wish that some of the people who had this problem would post
> > publically, and I guess we could just say, because they aren't being
> > public about it, it shouldn't go into a stable tree. And I don't have a
> > problem with that.
>
> I think accepting patches without our having a chance to see the
> problem sets a bad precedent. It's quite common to see patches that
> "solve" the problem, but do it in the wrong way.
>
> If the hardware is secret, maybe they could open a new, sanitized bug
> report? It should be easy to remove the valuable details from the
> dmesg log and oops.
I'll go ask again for them to do this, and I'll drop these patches from
the release.
thanks,
greg k-h
next prev parent reply other threads:[~2011-10-11 21:34 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 16:59 [00/38] 3.0.7-stable review Greg KH
2011-10-11 16:55 ` [01/38] PCI: Set PCI-E Max Payload Size on fabric Greg KH
2011-10-11 17:20 ` Benjamin LaHaise
2011-10-11 18:14 ` Bjorn Helgaas
2011-10-11 19:24 ` Greg KH
2011-10-11 19:47 ` Bjorn Helgaas
2011-10-11 19:56 ` Greg KH
2011-10-11 20:03 ` Benjamin LaHaise
2011-10-11 21:31 ` Greg KH
2011-10-11 20:22 ` Bjorn Helgaas
2011-10-11 21:32 ` Greg KH [this message]
2011-10-11 16:55 ` [02/38] PCI: export pcie_bus_configure_settings symbol Greg KH
2011-10-11 16:55 ` [03/38] PCI: Remove MRRS modification from MPS setting code Greg KH
2011-10-11 16:55 ` [04/38] pci: Dont crash when reading mpss from root complex Greg KH
2011-10-11 16:55 ` [05/38] Fix pointer dereference before call to pcie_bus_configure_settings Greg KH
2011-10-11 16:55 ` [06/38] PCI: Disable MPS configuration by default Greg KH
2011-10-11 16:55 ` [07/38] sparc64: Force the execute bit in OpenFirmwares translation entries Greg KH
2011-10-11 16:55 ` [08/38] sched/rt: Migrate equal priority tasks to available CPUs Greg KH
2011-10-11 16:55 ` [09/38] sched: Fix up wchan borkage Greg KH
2011-10-11 16:55 ` [10/38] ide-disk: Fix request requeuing Greg KH
2011-10-11 16:55 ` [11/38] posix-cpu-timers: Cure SMP wobbles Greg KH
2011-10-11 16:55 ` [12/38] lis3: fix regression of HP DriveGuard with 8bit chip Greg KH
2011-10-11 16:55 ` [13/38] ASoC: use a valid device for dev_err() in Zylonite Greg KH
2011-10-11 16:55 ` [14/38] ASoC: Fix setting update bits for WM8753_LADC and WM8753_RADC Greg KH
2011-10-11 16:55 ` [15/38] drm/radeon: Update AVIVO cursor coordinate origin before x/yorigin calculation Greg KH
2011-10-11 16:55 ` [16/38] drm/radeon/kms: Fix logic error in DP HPD handler Greg KH
2011-10-11 16:55 ` [17/38] drm/radeon/kms: fix regression in DP aux defer handling Greg KH
2011-10-11 16:55 ` [18/38] drm/radeon/kms: add retry limits for native DP aux defer Greg KH
2011-10-11 16:55 ` [19/38] drm/radeon/kms: fix channel_remap setup (v2) Greg KH
2011-10-11 16:55 ` [20/38] ptp: fix L2 event message recognition Greg KH
2011-10-11 16:55 ` [21/38] rt2x00: Serialize TX operations on a queue Greg KH
2011-10-11 16:55 ` [22/38] x86/PCI: use host bridge _CRS info on ASUS M2V-MX SE Greg KH
2011-10-11 16:55 ` [23/38] [SCSI] qla2xxx: Fix crash in qla2x00_abort_all_cmds() on unload Greg KH
2011-10-11 16:55 ` [24/38] [SCSI] libsas: fix panic when single phy is disabled on a wide port Greg KH
2011-10-11 16:55 ` [25/38] md: Avoid waking up a thread after it has been freed Greg KH
2011-10-11 16:55 ` [26/38] dm table: avoid crash if integrity profile changes Greg KH
2011-10-11 16:55 ` [27/38] mmc: mxs-mmc: fix clock rate setting Greg KH
2011-10-11 16:55 ` [28/38] exec: do not call request_module() twice from search_binary_handler() Greg KH
2011-10-11 16:55 ` [29/38] ARM: mach-ux500: enable fix for ARM errata 754322 Greg KH
2011-10-11 16:55 ` [30/38] drm/radeon/kms: retry aux transactions if there are status flags Greg KH
2011-10-11 16:55 ` [31/38] drm/radeon/kms: use hardcoded dig encoder to transmitter mapping for DCE4.1 Greg KH
2011-10-11 16:55 ` [32/38] ipv6: fix NULL dereference in udp6_ufo_fragment() Greg KH
2011-10-11 16:55 ` [33/38] ahci: Enable SB600 64bit DMA on Asus M3A Greg KH
2011-10-11 16:55 ` [34/38] MIPS: PM: Use struct syscore_ops instead of sysdevs for PM (v2) Greg KH
2011-10-11 16:55 ` [35/38] ftrace: Fix regression of :mod:module function enabling Greg KH
2011-10-11 16:55 ` [36/38] ftrace: Fix regression where ftrace breaks when modules are loaded Greg KH
2011-10-11 16:55 ` [37/38] ftrace: Fix warning when CONFIG_FUNCTION_TRACER is not defined Greg KH
2011-10-11 16:55 ` [38/38] e1000e: workaround for packet drop on 82579 at 100Mbps Greg KH
2011-10-11 17:00 ` [00/38] 3.0.7-stable review Greg KH
2011-10-17 15:05 ` Conny Seidel
2011-10-17 15:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011213204.GB3881@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bcrl@kvack.org \
--cc=bhelgaas@google.com \
--cc=greg@kroah.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@myri.com \
--cc=stable-review@kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.