From: Tejun Heo <tj@kernel.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-kernel@vger.kernel.org, jaxboe@fusionio.com,
christophe@saout.de, dm-devel@redhat.com, msnitzer@redhat.com
Subject: Re: [PATCH 2/2] blk-flush: fix invalid BUG_ON in blk_insert_flush
Date: Wed, 12 Oct 2011 15:18:28 -0700 [thread overview]
Message-ID: <20111012221828.GI6281@google.com> (raw)
In-Reply-To: <1318454562-25291-3-git-send-email-jmoyer@redhat.com>
On Wed, Oct 12, 2011 at 05:22:42PM -0400, Jeff Moyer wrote:
> A user reported a regression due to commit
> 4853abaae7e4a2af938115ce9071ef8684fb7af4 (block: fix flush
> machinery for stacking drivers with differring flush flags).
> Part of the problem is that blk_insert_flush required a
> single bio be attached to the request. In reality, having
> no attached bio is also a valid case, as can be observed with
> an empty flush.
>
> [1] http://www.redhat.com/archives/dm-devel/2011-September/msg00154.html
>
> Reported-by: Christophe Saout <christophe@saout.de>
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Duplicate SOB's and missing space after '/*' in the comment. Other
than that,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2011-10-12 22:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 21:22 [PATCH 0/2] block: fix flush regression introduced in 3.1-rc3 Jeff Moyer
2011-10-12 21:22 ` [PATCH 1/2] blk-flush: move the queue kick into blk_insert_cloned_request Jeff Moyer
2011-10-12 22:17 ` Tejun Heo
2011-10-14 15:05 ` [dm-devel] " Vivek Goyal
2011-10-12 21:22 ` [PATCH 2/2] blk-flush: fix invalid BUG_ON in blk_insert_flush Jeff Moyer
2011-10-12 22:18 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111012221828.GI6281@google.com \
--to=tj@kernel.org \
--cc=christophe@saout.de \
--cc=dm-devel@redhat.com \
--cc=jaxboe@fusionio.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=msnitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.