From: Wu Fengguang <fengguang.wu@intel.com>
To: Jan Kara <jack@suse.cz>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH 0/2 v4] writeback: Improve busyloop prevention and inode requeueing
Date: Thu, 13 Oct 2011 22:15:17 +0800 [thread overview]
Message-ID: <20111013141517.GA6938@localhost> (raw)
In-Reply-To: <1318453043-32057-1-git-send-email-jack@suse.cz>
On Thu, Oct 13, 2011 at 04:57:21AM +0800, Jan Kara wrote:
>
> Hello,
>
> this is a fourth version of my patch series improving busyloop prevention in
> writeback code and then replacing some redirty_tail() calls with requeue_io()
> to avoid postponing writeback for too long.
>
> Changes since v3:
> * Improved busyloop prevention to abort work which cannot make progress if we
> are retrying for too long or if there is some other work to do.
> * Increased maximum sleep time in the busy loop to avoid eating CPU power
> unnecessarily.
> * Removed wbc->pages_skipped check
>
> Thanks to Fengguang for review, testing and good suggestions.
Yeah the new version addresses my previous concerns, and the test
results are good in general:
3.1.0-rc8-ioless6a+ 3.1.0-rc8-ioless6-requeue6+
------------------------ ------------------------
58.23 -2.7% 56.65 thresh=100M/btrfs-10dd-4k-8p-4096M-100M:10-X
58.43 -2.0% 57.25 thresh=100M/btrfs-1dd-4k-8p-4096M-100M:10-X
58.53 -1.9% 57.42 thresh=100M/btrfs-2dd-4k-8p-4096M-100M:10-X
37.34 +0.1% 37.38 thresh=100M/ext3-10dd-4k-8p-4096M-100M:10-X
44.44 +0.5% 44.68 thresh=100M/ext3-1dd-4k-8p-4096M-100M:10-X
41.70 +2.0% 42.52 thresh=100M/ext3-2dd-4k-8p-4096M-100M:10-X
46.45 -0.3% 46.33 thresh=100M/ext4-10dd-4k-8p-4096M-100M:10-X
56.60 -1.5% 55.75 thresh=100M/ext4-1dd-4k-8p-4096M-100M:10-X
54.14 -0.9% 53.64 thresh=100M/ext4-2dd-4k-8p-4096M-100M:10-X
44.53 -2.6% 43.37 thresh=100M/xfs-10dd-4k-8p-4096M-100M:10-X
55.89 -2.3% 54.58 thresh=100M/xfs-1dd-4k-8p-4096M-100M:10-X
51.11 +0.0% 51.12 thresh=100M/xfs-2dd-4k-8p-4096M-100M:10-X
56.55 -1.3% 55.82 thresh=1G/btrfs-100dd-4k-8p-4096M-1024M:10-X
56.11 -0.9% 55.60 thresh=1G/btrfs-10dd-4k-8p-4096M-1024M:10-X
56.21 -0.9% 55.69 thresh=1G/btrfs-1dd-4k-8p-4096M-1024M:10-X
30.66 -1.3% 30.26 thresh=1G/ext3-100dd-4k-8p-4096M-1024M:10-X
35.24 -1.5% 34.72 thresh=1G/ext3-10dd-4k-8p-4096M-1024M:10-X
43.58 -0.7% 43.28 thresh=1G/ext3-1dd-4k-8p-4096M-1024M:10-X
50.42 -0.8% 50.01 thresh=1G/ext4-100dd-4k-8p-4096M-1024M:10-X
56.23 -2.1% 55.03 thresh=1G/ext4-10dd-4k-8p-4096M-1024M:10-X
58.12 -1.2% 57.42 thresh=1G/ext4-1dd-4k-8p-4096M-1024M:10-X
41.76 -5.9% 39.31 thresh=1G/xfs-100dd-4k-8p-4096M-1024M:10-X
48.34 +0.8% 48.70 thresh=1G/xfs-10dd-4k-8p-4096M-1024M:10-X
52.36 -2.0% 51.29 thresh=1G/xfs-1dd-4k-8p-4096M-1024M:10-X
32.09 -0.0% 32.08 thresh=1M/ext4-10dd-4k-8p-4096M-1M:10-X
51.36 +3.3% 53.05 thresh=1M/ext4-1dd-4k-8p-4096M-1M:10-X
46.93 +0.4% 47.13 thresh=1M/ext4-2dd-4k-8p-4096M-1M:10-X
28.68 -4.9% 27.28 thresh=1M/xfs-10dd-4k-8p-4096M-1M:10-X
51.95 +3.0% 53.51 thresh=1M/xfs-1dd-4k-8p-4096M-1M:10-X
47.07 -15.5% 39.78 thresh=1M/xfs-2dd-4k-8p-4096M-1M:10-X
54.37 +3.0% 56.02 thresh=8M/btrfs-10dd-4k-8p-4096M-8M:10-X
56.12 +3.5% 58.06 thresh=8M/btrfs-1dd-4k-8p-4096M-8M:10-X
56.22 +2.9% 57.87 thresh=8M/btrfs-2dd-4k-8p-4096M-8M:10-X
32.21 +1.1% 32.55 thresh=8M/ext3-10dd-4k-8p-4096M-8M:10-X
45.37 +1.6% 46.10 thresh=8M/ext3-1dd-4k-8p-4096M-8M:10-X
43.71 +2.5% 44.81 thresh=8M/ext3-2dd-4k-8p-4096M-8M:10-X
35.58 +0.9% 35.90 thresh=8M/ext4-10dd-4k-8p-4096M-8M:10-X
56.39 -0.9% 55.91 thresh=8M/ext4-1dd-4k-8p-4096M-8M:10-X
51.26 +0.7% 51.61 thresh=8M/ext4-2dd-4k-8p-4096M-8M:10-X
31.07 -0.3% 30.97 thresh=8M/xfs-10dd-4k-8p-4096M-8M:10-X
55.44 -1.4% 54.68 thresh=8M/xfs-1dd-4k-8p-4096M-8M:10-X
47.59 -0.7% 47.25 thresh=8M/xfs-2dd-4k-8p-4096M-8M:10-X
2016.38 -0.7% 2002.40 TOTAL
Thanks,
Fengguang
prev parent reply other threads:[~2011-10-13 14:15 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 20:57 [PATCH 0/2 v4] writeback: Improve busyloop prevention and inode requeueing Jan Kara
2011-10-12 20:57 ` [PATCH 1/2] writeback: Improve busyloop prevention Jan Kara
2011-10-13 14:26 ` Wu Fengguang
2011-10-13 20:13 ` Jan Kara
2011-10-14 7:18 ` Christoph Hellwig
2011-10-14 19:31 ` Chris Mason
[not found] ` <20111013143939.GA9691@localhost>
2011-10-13 20:18 ` Jan Kara
2011-10-14 16:00 ` Wu Fengguang
2011-10-14 16:28 ` Wu Fengguang
2011-10-18 0:51 ` Jan Kara
2011-10-18 14:35 ` Wu Fengguang
2011-10-19 11:56 ` Jan Kara
2011-10-19 13:25 ` Wu Fengguang
2011-10-19 13:30 ` Wu Fengguang
2011-10-19 13:35 ` Wu Fengguang
2011-10-20 12:09 ` Wu Fengguang
2011-10-20 12:33 ` Wu Fengguang
2011-10-20 13:39 ` Wu Fengguang
2011-10-20 22:26 ` Jan Kara
2011-10-22 4:20 ` Wu Fengguang
2011-10-24 15:45 ` Jan Kara
[not found] ` <20111027063133.GA10146@localhost>
2011-10-27 20:31 ` Jan Kara
[not found] ` <20111101134231.GA31718@localhost>
2011-11-01 21:53 ` Jan Kara
2011-11-02 17:25 ` Wu Fengguang
[not found] ` <20111102185603.GA4034@localhost>
2011-11-03 1:51 ` Jan Kara
2011-11-03 14:52 ` Wu Fengguang
[not found] ` <20111104152054.GA11577@localhost>
2011-11-08 23:52 ` Jan Kara
2011-11-09 13:51 ` Wu Fengguang
2011-11-10 14:50 ` Jan Kara
2011-12-05 8:02 ` Wu Fengguang
2011-12-07 10:13 ` Jan Kara
2011-12-07 11:45 ` Wu Fengguang
[not found] ` <20111027064745.GA14017@localhost>
2011-10-27 20:50 ` Jan Kara
2011-10-20 9:46 ` Christoph Hellwig
2011-10-20 15:32 ` Jan Kara
2011-10-15 12:41 ` Wu Fengguang
2011-10-12 20:57 ` [PATCH 2/2] writeback: Replace some redirty_tail() calls with requeue_io() Jan Kara
2011-10-13 14:30 ` Wu Fengguang
2011-10-13 14:15 ` Wu Fengguang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013141517.GA6938@localhost \
--to=fengguang.wu@intel.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.