From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"JBeulich@suse.com" <JBeulich@suse.com>
Subject: Other things we need to do with backend/blkfront Was:Re: Re: [PATCH 2 of 3] interface: Flesh out the BLKIF_OP_DISCARD description
Date: Thu, 13 Oct 2011 11:32:34 -0400 [thread overview]
Message-ID: <20111013153234.GD9820@phenom.oracle.com> (raw)
In-Reply-To: <1318492807.21903.789.camel@zakaz.uk.xensource.com>
> Could we simplify and say that blkback won't expose discard support
> unless the underlying block device is correctly aligned for it? i.e.
> encourage people to align their underlying storage correctly? Presumably
> doing that has other benefits?
It got me thinking that we could do this - but I do not think that should
be spelled out in the interface. Rather it is up to the backend to either
expose it or not. The check for -1 in backend for that should do it. Keep
in mind that the discard operation is a hint, nothing else.
It also got me thinking about the aligment offset - which we do not
expose to the frontend. That is the one where the 63 sector DOS partition
ends up skewing up the whole disk layout. That is seperate from discard
operations.
It is more of a XenBus attribute. Then there is also the device serial
number which we don't expose either.
next prev parent reply other threads:[~2011-10-13 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 22:12 [PATCH 0 of 3] Patches to alter BLKIF_OP_TRIM to BLKIF_OP_DISCARD (v4) Konrad Rzeszutek Wilk
2011-10-12 22:12 ` [PATCH 1 of 3] interface: rename of trim to discard in blkif.h Konrad Rzeszutek Wilk
2011-10-12 22:12 ` [PATCH 2 of 3] interface: Flesh out the BLKIF_OP_DISCARD description Konrad Rzeszutek Wilk
2011-10-13 8:00 ` Ian Campbell
2011-10-13 14:32 ` Konrad Rzeszutek Wilk
2011-10-13 15:04 ` Konrad Rzeszutek Wilk
2011-10-13 15:32 ` Konrad Rzeszutek Wilk [this message]
2011-10-12 22:12 ` [PATCH 3 of 3] interface: add 'discard-secure' and BLKIF_DISCARD_SECURE Konrad Rzeszutek Wilk
2011-10-13 7:59 ` Ian Campbell
2011-10-13 14:12 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013153234.GD9820@phenom.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.