From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/4] ata_piix: CodingStyle fixes
Date: Thu, 13 Oct 2011 15:43:29 +0200 [thread overview]
Message-ID: <201110131543.30235.bzolnier@gmail.com> (raw)
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] ata_piix: CodingStyle fixes
CodingStyle fixes for piix_port_info[].
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ata/ata_piix.c | 68 ++++++++++++++-----------------------------------
1 file changed, 20 insertions(+), 48 deletions(-)
Index: b/drivers/ata/ata_piix.c
===================================================================
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -473,131 +473,103 @@ static const struct piix_map_db *piix_ma
};
static struct ata_port_info piix_port_info[] = {
- [piix_pata_mwdma] = /* PIIX3 MWDMA only */
- {
+ [piix_pata_mwdma] = { /* PIIX3 MWDMA only */
.flags = PIIX_PATA_FLAGS,
.pio_mask = ATA_PIO4,
- .mwdma_mask = ATA_MWDMA12_ONLY, /* mwdma1-2 ?? CHECK 0 should be ok but slow */
+ .mwdma_mask = ATA_MWDMA12_ONLY, /* check if MWDMA0 is OK */
.port_ops = &piix_pata_ops,
},
-
- [piix_pata_33] = /* PIIX4 at 33MHz */
- {
+ [piix_pata_33] = { /* PIIX4 at 33MHz */
.flags = PIIX_PATA_FLAGS,
.pio_mask = ATA_PIO4,
- .mwdma_mask = ATA_MWDMA12_ONLY, /* mwdma1-2 ?? CHECK 0 should be ok but slow */
+ .mwdma_mask = ATA_MWDMA12_ONLY, /* check if MWDMA0 is OK */
.udma_mask = ATA_UDMA2,
.port_ops = &piix_pata_ops,
},
-
- [ich_pata_33] = /* ICH0 - ICH at 33Mhz*/
- {
+ [ich_pata_33] = { /* ICH0 - ICH at 33Mhz*/
.flags = PIIX_PATA_FLAGS,
- .pio_mask = ATA_PIO4,
- .mwdma_mask = ATA_MWDMA12_ONLY, /* Check: maybe MWDMA0 is ok */
+ .pio_mask = ATA_PIO4,
+ .mwdma_mask = ATA_MWDMA12_ONLY, /* check if MWDMA0 is OK */
.udma_mask = ATA_UDMA2,
.port_ops = &ich_pata_ops,
},
-
- [ich_pata_66] = /* ICH controllers up to 66MHz */
- {
+ [ich_pata_66] = { /* ICH controllers up to 66MHz */
.flags = PIIX_PATA_FLAGS,
- .pio_mask = ATA_PIO4,
+ .pio_mask = ATA_PIO4,
.mwdma_mask = ATA_MWDMA12_ONLY, /* MWDMA0 is broken on chip */
.udma_mask = ATA_UDMA4,
.port_ops = &ich_pata_ops,
},
-
- [ich_pata_100] =
- {
+ [ich_pata_100] = {
.flags = PIIX_PATA_FLAGS | PIIX_FLAG_CHECKINTR,
.pio_mask = ATA_PIO4,
.mwdma_mask = ATA_MWDMA12_ONLY,
.udma_mask = ATA_UDMA5,
.port_ops = &ich_pata_ops,
},
-
- [ich_pata_100_nomwdma1] =
- {
+ [ich_pata_100_nomwdma1] = {
.flags = PIIX_PATA_FLAGS | PIIX_FLAG_CHECKINTR,
.pio_mask = ATA_PIO4,
.mwdma_mask = ATA_MWDMA2_ONLY,
.udma_mask = ATA_UDMA5,
.port_ops = &ich_pata_ops,
},
-
- [ich5_sata] =
- {
+ [ich5_sata] = {
.flags = PIIX_SATA_FLAGS,
.pio_mask = ATA_PIO4,
.mwdma_mask = ATA_MWDMA2,
.udma_mask = ATA_UDMA6,
.port_ops = &piix_sata_ops,
},
-
- [ich6_sata] =
- {
+ [ich6_sata] = {
.flags = PIIX_SATA_FLAGS,
.pio_mask = ATA_PIO4,
.mwdma_mask = ATA_MWDMA2,
.udma_mask = ATA_UDMA6,
.port_ops = &piix_sata_ops,
},
-
- [ich6m_sata] =
- {
+ [ich6m_sata] = {
.flags = PIIX_SATA_FLAGS,
.pio_mask = ATA_PIO4,
.mwdma_mask = ATA_MWDMA2,
.udma_mask = ATA_UDMA6,
.port_ops = &piix_sata_ops,
},
-
- [ich8_sata] =
- {
+ [ich8_sata] = {
.flags = PIIX_SATA_FLAGS | PIIX_FLAG_SIDPR,
.pio_mask = ATA_PIO4,
.mwdma_mask = ATA_MWDMA2,
.udma_mask = ATA_UDMA6,
.port_ops = &piix_sata_ops,
},
-
- [ich8_2port_sata] =
- {
+ [ich8_2port_sata] = {
.flags = PIIX_SATA_FLAGS | PIIX_FLAG_SIDPR,
.pio_mask = ATA_PIO4,
.mwdma_mask = ATA_MWDMA2,
.udma_mask = ATA_UDMA6,
.port_ops = &piix_sata_ops,
},
-
- [tolapai_sata] =
- {
+ [tolapai_sata] = {
.flags = PIIX_SATA_FLAGS,
.pio_mask = ATA_PIO4,
.mwdma_mask = ATA_MWDMA2,
.udma_mask = ATA_UDMA6,
.port_ops = &piix_sata_ops,
},
-
- [ich8m_apple_sata] =
- {
+ [ich8m_apple_sata] = {
.flags = PIIX_SATA_FLAGS,
.pio_mask = ATA_PIO4,
.mwdma_mask = ATA_MWDMA2,
.udma_mask = ATA_UDMA6,
.port_ops = &piix_sata_ops,
},
-
- [piix_pata_vmw] =
- {
+ [piix_pata_vmw] = {
.flags = PIIX_PATA_FLAGS,
.pio_mask = ATA_PIO4,
- .mwdma_mask = ATA_MWDMA12_ONLY, /* mwdma1-2 ?? CHECK 0 should be ok but slow */
+ .mwdma_mask = ATA_MWDMA12_ONLY, /* check if MWDMA0 is OK */
.udma_mask = ATA_UDMA2,
.port_ops = &piix_vmw_ops,
},
-
};
static struct pci_bits piix_enable_bits[] = {
next reply other threads:[~2011-10-13 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 13:43 Bartlomiej Zolnierkiewicz [this message]
2011-10-14 17:36 ` [PATCH v2 3/4] ata_piix: CodingStyle fixes Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110131543.30235.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.