From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 6/6] fdt: add decode helper library
Date: Thu, 13 Oct 2011 19:01:48 -0400 [thread overview]
Message-ID: <201110131901.50980.vapier@gentoo.org> (raw)
In-Reply-To: <CAPnjgZ3D-SsDbr3m7XmCi9XjkDij7Bt9x-WXdfU-GRF6rN1g1A@mail.gmail.com>
On Thursday 13 October 2011 17:28:10 Simon Glass wrote:
> On Thu, Oct 13, 2011 at 1:33 PM, Mike Frysinger wrote:
> > On Tuesday 11 October 2011 18:26:11 Simon Glass wrote:
> >> +int fdtdec_next_alias(const void *blob, const char *name,
> >> + enum fdt_compat_id id, int *upto)
> >> +{
> >> +#define MAX_STR_LEN 20
> >> + char str[MAX_STR_LEN + 20];
> >> + int node, err;
> >> +
> >> + sprintf(str, "%.*s%d", MAX_STR_LEN, name, *upto);
> >
> > where's that "20" coming from ? just arbitrarily defined ? might want
> > to add an assert(strlen(name) <= MAX_STR_LEN).
>
> OK. Of course I would like to use snprintf()...
i think that might be nicer anyways than %.*s
char str[40]; /* an arbitrary len */
snprintf(str, sizeof(str), "%s%d", name, *upto);
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111013/0f112de4/attachment.pgp
next prev parent reply other threads:[~2011-10-13 23:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 22:26 [U-Boot] [PATCH v3 0/6] Run-time configuration of U-Boot via a flat device tree (fdt) Simon Glass
2011-10-11 22:26 ` [U-Boot] [PATCH v3 1/6] fdt: ARM: Add device tree control of U-Boot (CONFIG_OF_CONTROL) Simon Glass
2011-10-11 23:39 ` Stephen Warren
2011-10-11 22:26 ` [U-Boot] [PATCH v3 2/6] fdt: Add support for embedded device tree (CONFIG_OF_EMBED) Simon Glass
2011-10-13 21:13 ` Stephen Warren
2011-10-13 21:22 ` Simon Glass
2011-10-13 21:21 ` Stephen Warren
2011-10-13 21:25 ` Simon Glass
2011-10-13 21:50 ` Stephen Warren
2011-10-15 5:21 ` Simon Glass
2011-10-15 5:46 ` Grant Likely
2011-10-15 14:51 ` Simon Glass
2011-10-13 22:58 ` Mike Frysinger
2011-10-11 22:26 ` [U-Boot] [PATCH v3 3/6] fdt: Add support for a separate device tree (CONFIG_OF_SEPARATE) Simon Glass
2011-10-13 21:36 ` Stephen Warren
2011-10-15 15:12 ` Simon Glass
2011-10-11 22:26 ` [U-Boot] [PATCH v3 4/6] fdt: ARM: Implement embedded and separate device tree Simon Glass
2011-10-13 21:39 ` Stephen Warren
2011-10-15 15:15 ` Simon Glass
2011-10-11 22:26 ` [U-Boot] [PATCH v3 5/6] fdt: ARM: Add fdtcontroladdr to set device tree address in environment Simon Glass
2011-10-13 20:27 ` Mike Frysinger
2011-10-13 21:08 ` Simon Glass
2011-10-15 15:18 ` Simon Glass
2011-10-11 22:26 ` [U-Boot] [PATCH v3 6/6] fdt: add decode helper library Simon Glass
2011-10-13 20:33 ` Mike Frysinger
2011-10-13 21:28 ` Simon Glass
2011-10-13 23:01 ` Mike Frysinger [this message]
2011-10-13 23:16 ` Simon Glass
2011-10-13 23:32 ` Mike Frysinger
2011-10-14 18:12 ` Kumar Gala
2011-10-14 18:21 ` Simon Glass
2011-10-15 1:42 ` Aaron Williams
2011-10-15 2:16 ` Simon Glass
2011-10-11 23:37 ` [U-Boot] [PATCH v3 0/6] Run-time configuration of U-Boot via a flat device tree (fdt) Stephen Warren
2011-10-11 23:54 ` Simon Glass
2011-10-12 1:00 ` Jason
2011-10-12 1:07 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110131901.50980.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.