All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Julian Scheel <julian@jusst.de>
Cc: alsa-devel@alsa-project.org, Stephen Warren <swarren@nvidia.com>,
	lrg@slimlogic.co.uk
Subject: Re: [PATCH] ASoC: WM8903: Implement DMIC support
Date: Fri, 14 Oct 2011 13:16:14 +0100	[thread overview]
Message-ID: <20111014121614.GF2966@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1318588461.2686.9.camel@localhost.localdomain>

On Fri, Oct 14, 2011 at 12:34:21PM +0200, Julian Scheel wrote:

> actually the wm8903 codec needs GPIO1 and GPIO2 to be configured
> properly to be able to use DMIC actually. I would propose to
> automatically configure these to DMIC-mode whenever ADCINPUT is set to
> DMIC. Would you agree with this procedure?
> I would prepare a patch which changes all relevant registers then.

I'd go the other way and disable the DMIC support if the GPIOs aren't
configured appropriately in the platform data.  Since the DMIC is
selectable at runtime by random applications in most systems if it
forced the GPIOs into DMIC mode it could break functionality on systems
that don't actually have the DMIC wired up.  We've got code for this in
WM8962 for example.

      reply	other threads:[~2011-10-14 12:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-19  2:58 [PATCH] ASoC: WM8903: Implement DMIC support Stephen Warren
2011-04-20 11:10 ` Liam Girdwood
2011-04-20 13:00 ` Mark Brown
2011-10-14 10:34 ` Julian Scheel
2011-10-14 12:16   ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111014121614.GF2966@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=julian@jusst.de \
    --cc=lrg@slimlogic.co.uk \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.