From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: Re: [PATCH] xen/gntdev: Fix sleep-inside-spinlock Date: Fri, 14 Oct 2011 09:54:59 -0400 Message-ID: <20111014135459.GA4577@phenom.oracle.com> References: <1318353219.21925.80.camel@Palantir> <20111011173228.GB32406@phenom.oracle.com> <4E9495F6.4070301@tycho.nsa.gov> <1318586226.5062.21.camel@Palantir> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1318586226.5062.21.camel@Palantir> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dario Faggioli Cc: Daniel De Graaf , xen-devel List-Id: xen-devel@lists.xenproject.org On Fri, Oct 14, 2011 at 11:57:05AM +0200, Dario Faggioli wrote: > On Tue, 2011-10-11 at 15:16 -0400, Daniel De Graaf wrote: > > gntdev_put_map tries to acquire a mutex when freeing pages back to the > > xenballoon pool, so it cannot be called with a spinlock held. In > > gntdev_release, the spinlock is not needed as we are freeing the > > structure later; in the ioctl, only the list manipulation needs to be > > under the lock. > > > > Reported-By: Dario Faggioli > > Signed-off-by: Daniel De Graaf > > > Ok, I finally manage in testing this, and it actually cures the issue > here! > > You can add a tested-by tag if you like. Just, if you don't mind, use my > corp. e-mail for (both?) the tag(s): Sure. Thx for checking it.